Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202012] Adjust 7260 buffer sizes to accomodate extra lossless queues #11049

Closed
wants to merge 1,226 commits into from

Conversation

neethajohn
Copy link
Contributor

Backport changes from #11018

mssonicbld and others added 30 commits January 19, 2022 22:46
…995,CS00012220761,CS00012211718,CS00012208995,CS00012220761, and CS00012225760 (sonic-net#9815)
…t#9810)

ab7a6ed [patch] Cisco Kernel Patches to support 4.19.x kernel

Signed-off-by: Kevin(Shengkai) Wang <[email protected]>
[sonic-linkmgrd][master] submodule update

Commits added:
0c23756 Jing Zhang      2022-01-19      Linkmgrd subscribing State DB route event  (sonic-net#13)
12b9951 Longxiang Lyu   2021-12-13      Add TLV support to ICMP payload (sonic-net#11)
3eedda3 Longxiang Lyu   2022-01-06      Add missing intermediate states (sonic-net#16)
8da4982 Ying Xie        2022-01-04      [linkmgrd] update README, set coding style guidance (sonic-net#15)
a897cf8 Longxiang Lyu   2021-12-13      Improve PR template (sonic-net#16)
6fec701 Jing Zhang      2021-12-06      Add pull request template for linkmgrd repo (sonic-net#9)


signed-off-by: Jing Zhang [email protected]
…dump (sonic-net#9521)

Why I did it
Eliminate benign firsttime boot error reported when running on platforms that do not support kdump.

How I did it
Change rc.local to check for presence of the file /etc/default/kdump-tools before referencing it.

How to verify it
Install a new image on an armhf or arm64 platform and check for a failed reference to /etc/default/kdump-tools on firsttime boot.
- Backport logrotate configuration for `arista*.log` files
Commits:

02dea43 [202012] Add support for BFD notification (sonic-net#990)
337fd97 Change sonic-buildimage.vs artifact source from CI build to official build. (sonic-net#992)
490f442 Support for cisco-8000 platform for sonic-sairedis/syncd (sonic-net#823)
Update submodule sonic-sairedis that contains the following commit:

Change the log severity leve from ERROR to NOTICE if getStatus is not supported by vendor (sonic-net#908) (sonic-net#991)
…ster branch (sonic-net#7513)

Port the fix to get the pci_device ID from asic.conf file and update the "asic_id" field in DEVICE_METADATA with the pci_device_Id.

Ref: sonic-net#4705
…#9013)

This makes it possible to install the debug symbols if needed. Also install
the package into the debug version of sonic-dhcp-relay container.

Signed-off-by: Saikrishna Arcot <[email protected]>
Tested on a Celestica Seastone2 DX030 switch

Testing scenarios:
- Various QSFP ports in both normal and breakout config.
- 100G and 40G link speed show different colors.
- SFP1 port works.

Signed-off-by: Christian Svensson <[email protected]>
[buffer orch] Bugfix: Don't query counter SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES on a pool where it is not supported (sonic-net#1857) (sonic-net#2106)

Signed-off-by: Volodymyr Samotiy <[email protected]>
….1218 (sonic-net#9818)

- Why I did it
To include latest fixes.
1. On CMIS modules, after low power configuration, the firmware waited for the module state to be ModuleReady instead of ModuleLowPower causing delays.
2. When connecting SN4600C, 100GbE port with CWDM4 module (Gen 3.0), link up time is 30 seconds.
3. Add T1 ECMP Overlay support

- How I did it
Updated SDK/SAI submodule and relevant makefiles with the required versions.

- How to verify it
Build an image and run tests from "sonic-mgmt".

Signed-off-by: Volodymyr Samotiy <[email protected]>
…onic-net#9697)

Why I did it
Cherry pick changes in sonic-net#9197 to 202012 branch
Add bgpcfgd support to advertise routes.

How I did it
Make bgpcfgd subscribe to the ADVERTISE_NETWORK table in STATE_DB and configure route advertisement accordingly.

How to verify it
Added unit tests in bgpcfgd and verify on KVM about route advertisement.
Commits:
*6d66079 - 2022-01-26 : [202012] [vnetorch] Add ECMP support for vnet tunnel routes with endpoint health monitoring (sonic-net#2104) [Shi Su]
Signed-off-by: Saikrishna Arcot <[email protected]>
(cherry picked from commit d536592)
This is to save about 40MB of disk space, since 5 containers
individually install this package.

Signed-off-by: Saikrishna Arcot <[email protected]>
(cherry picked from commit bd479ca)
Why I did it
To enable test support for BFD-related features, the PTF docker needs to have the proper support for BFD. This PR aims to add BFD support in ptf docker.

How I did it
Clone and build OpenBFDD for PTF docker.

How to verify it
Build locally and verify BFD is supported.
Why I did it
the strcpy and buffer allocation is not safe, it corrupts 1 byte on the stack. Depending on the memory layout, it may or may not cause issue immediately.
message type is not validated before updating the counter. Which could cause segment fault.

How I did it
Remove the unsafe strcpy, use config->interface.c_str() instead.
Check message type before updating counters.

How to verify it
The issue (1) caused segment fault on a specific platform. The fix was validated there. Issue (2) was precautionary. Added log in case it triggers.
Signed-off-by: vaibhav-dahiya <[email protected]>
How I did it
Advance swss submodule head to include:

c3fb52b 2022-02-04 | Fix for missing lossless PG profile on certain ports (sonic-swss-common update for Vnet tables sonic-net#2133) (HEAD -> 202012, github/202012) [Ying Xie]

Signed-off-by: Ying Xie [email protected]
[sonic-linkmgrd][202012] submodule update

ef1f5eb Jing Zhang Feb 3 09:37:25 2022 [linkmgrd] linkmgrd subscribes MUX_CABLE_INFO table to handle peer OIR events (sonic-net#17)
bcd74b4 Jing Zhang Feb 1 09:52:00 2022 Collect ICMP packet loss information (sonic-net#14)

sign-off: Jing Zhang [email protected]
…net#9419)

Why I did it
Fixes sonic-net#8980 partly.

The corresponding changes in sonic-sairedis is here :
sonic-net/sonic-sairedis#975

How I did it
Include changes from both repos and build an image for verification.

How to verify it
Trigger fast-reboot with the changes, see the attribute SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL being set at the SAI level.

Signed-off-by: Thushar Gowda <[email protected]>
neethajohn and others added 27 commits May 27, 2022 17:00
…et#10941)

Signed-off-by: Neetha John <[email protected]>

Why I did it
There was a typo in hwsku specified as part of sonic-net#10889

How I did it
Replaced with the correct hwsku

How to verify it
test_cfggen.py is passing
Why I did it
To remove the ipmihelper.py in S5248f directory to prevent the image label being marked 'dirty', due to the file being replaced by the ipmihelper.py in common folder during build.

How I did it
Remove ipmihelper.py in S5248f directory.

How to verify it
Build a broadcom image and verify that the tracked files are not modified.

Which release branch to backport (provide reason below if selected)
 201811
 201911
 202006
 202012
 202106
 202111
Description for the changelog
DellEMC S5248f : Remove duplicate ipmihelper.py

Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)
[sonic-linkmgrd][202012] submodule updates

489cf3 Jing Zhang Wed May 18 09:59:02 2022 -0700 Avoid switching active when LinkState == Down (sonic-net#77)
a6c9713 Jing Zhang Tue May 24 11:03:54 2022 -0700 [202012] Add option to enable or disable default route related feature (sonic-net#72)
dbb607d Jing Zhang Thu May 12 08:19:20 2022 -0700 [ci]: uplift diff coverage threshold to 80% (sonic-net#71)

sign-off: Jing Zhang [email protected]
…ace config db (sonic-net#10475)

Why I did it
Cherry-pick of: sonic-net#7632
portconfig.py gets PORT table from config_db if it is present. If not, port_config.ini files are parsed.
For multi-asic platform, if namespace is passed to get_port_config(), config_db connection was done to host namespace always and not to asic specific namespace.
Provides fix for: sonic-net#7161

How I did it
Modify db connection function to connect to namespace config_db.

How to verify it
Unit-test passed.
Verified on multi-asic VS platform.
…l_qos_remap (sonic-net#10930)

[202012][cherry-pick] Define `SYSTEM_DEFAULTS` table to control tunnel_qos_remap (sonic-net#10930)

Signed-off-by: bingwang <[email protected]>
Why I did it
Python2 not support to install protobuf>=4.21.
… not specified (sonic-net#10971) (sonic-net#10976)

Why I did it
It is to fix issue: sonic-net#10952
[Build]: Support to use the base image version when a package version not specified
Update sonic-swss-common submodule pointer to include the following:

fb89310 - (HEAD, origin/202012) [Overlay ECMP] add new table schema for bgp profile [sonic-utilities]: Update submodule; Add commands to sudoers as necessary sonic-net#608 (10 hours ago)
3632090 - [ci] Update azure pipeline branch variable reference. (4 weeks ago)
…nic-net#10938)


Signed-off-by: vaibhav-dahiya <[email protected]>

This PR adds the following commits are added in sonic-platform-common
ac25515 (HEAD -> 202012, origin/202012) [Credo][Ycable] changes for
synchronizing executing Telemetry API's when mux toggle is inprogress
(sonic-net#280)
fb304c1 [sonic_ssd] Nokia-7215: "show platform ssdhealth" not showing
health percent (sonic-net#279)
8bfe9c0 [Credo][Ycable] improve logging for Server Powered off/Faulty
cables (sonic-net#272)

The following commits are added in sonic-platform-daemons
6695c55 (HEAD -> 202012, origin/202012) [ycabled] fix the posting for
mux_cable_static_info per downlink when ycabled is spawned;
synchronizing executing Telemetry API (sonic-net#257)
6a315ae (HEAD -> 202012, origin/202012) [ycabled] Fix some syntax
warnings in ycabled (sonic-net#263)
…in buster-backports (sonic-net#10910)

* Use buster-backports version
* Use dget dsc file instead source repo
* Update make files
* Upgrade openssh-client to 8.4 in base image
* Remove useless installation
* Install openssh-server from buster-backports in build_debian
* Update dev buster package version list

Signed-off-by: Jing Kan [email protected]
…back traffic (sonic-net#10608)

* Update qos config to clear queues for bounced back traffic

Signed-off-by: bingwang <[email protected]>
…) (sonic-net#10858)

Why I did it
Introduce 2 sub jobs for kvmtest t0 job in sonic-mgmt repo in PR sonic-net/sonic-mgmt#4861
But in sonic-buildimage repo, because section parameter is null, it always run the part 2 test scripts in kvmtest t0 job.
It missed the part 1 test scripts in kvmtest.sh.

How I did it
Split kvmtest t0 job into two sub jobs such as sonic-mgmt repo and run them in parallel to save time.

How to verify it
Submit PR will trigger the pipeline to run.

Signed-off-by: Zhaohui Sun <[email protected]>
(cherry picked from commit 4402872)

Co-authored-by: Zhaohui Sun <[email protected]>
544e4c2 (origin/202012) [ci] Paralize azure pipeline (sonic-net#1044)
45b310d Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute (sonic-net#1016)
9e56674 Advance submodule SAI for 202012 branch (sonic-net#1032)

Signed-off-by: bingwang <[email protected]>
* [Tunnel PFC] Add property for tunnel PFC

Replace the config.bcm file with j2 template file
- Add 'sai_remap_prio_on_tnl_egress=1' property when device metadata local
- Host subtype is 'dualtor'
- Change sai.profile foe the new config.bcm.j2
…onic-net#11018)

Why I did it
As part of PCBB changes, we need to enable 2 extra lossless queues. The changes in this PR are done to adjust only the reserved sizes on Th2 for the additional 2 lossless queues
Calculations are done based on 40 downlinks for T1 and 16 uplinks for dual ToR

How to verify it
Verified that the rendering works fine on Th2 dut
Unit tests have been updated to reflect the modified buffer sizes when pcbb is enabled. There are existing testcases that will test the original buffer sizes when pcbb is disabled. With these changes, was able to build sonic-config-engine wheel successfully

Signed-off-by: Neetha John <[email protected]>
…queues (sonic-net#11018)"

This reverts commit 21f14dc.

unit test needs to be cherry-picked.
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
@neethajohn
Copy link
Contributor Author

close. wrong branch

@neethajohn neethajohn closed this Jun 6, 2022
@neethajohn neethajohn deleted the pcbb_th2_mmu_202012 branch June 7, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.