Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute #9419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass fast reboot option to syncd so that SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL gets triggered Signed-off-by: Thushar Gowda <[email protected]>
yxieca
approved these changes
Dec 22, 2021
|
@yxieca can this now be merged? |
|
@tbgowda please create an PR to move sairedis submodule head. |
5 tasks
qiluo-msft
pushed a commit
that referenced
this pull request
Feb 8, 2022
Why I did it Fixes #8980 partly. The corresponding changes in sonic-sairedis is here : sonic-net/sonic-sairedis#975 How I did it Include changes from both repos and build an image for verification. How to verify it Trigger fast-reboot with the changes, see the attribute SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL being set at the SAI level. Signed-off-by: Thushar Gowda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass fast reboot option to syncd so that SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL gets triggered
Signed-off-by: Thushar Gowda [email protected]
Why I did it
Fixes #8980 partly.
The corresponding changes in sonic-sairedis is here :
sonic-net/sonic-sairedis#975
How I did it
Include changes from both repos and build an image for verification.
How to verify it
Trigger fast-reboot with the changes, see the attribute SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL being set at the SAI level.
Which release branch to backport (provide reason below if selected)
Ideally it is preferred we back port to all branches where fast-reboot is supported. However, 202012 seems like a critical release train.
Description for the changelog
Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL in case of fast-reboot