[dhcp6relay] Add dhcpv6 option check (#10486) #10808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit cfdb843)
|
Holding off merging until #10785 is resolved |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
May 21, 2022
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
…-net#10819) (cherry picked from commit 2ead3aa)
lguohan
reviewed
May 30, 2022
src/dhcp6relay/src/relay.cpp
Outdated
| default: | ||
| case DHCPv6_MESSAGE_TYPE_SOLICIT: | ||
| case DHCPv6_MESSAGE_TYPE_REQUEST: | ||
| case DHCPv6_MESSAGE_TYPE_CONFIRM: |
There was a problem hiding this comment.
make sure you have uniform identation
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit cfdb843)
(cherry picked from commit 2ead3aa)
Why I did it
To prevent relaying client packets with malformed payload
How I did it
Check for invalid dhcpv6 options
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)