Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute for all platforms based on capability Signed-off-by: Thushar Gowda <[email protected]>
|
|
Merged
5 tasks
kcudnik
approved these changes
Dec 10, 2021
|
Hello, can this be merged? It looks like there is a baseline failure with the vstest unrelated to these changes? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @yxieca , The failing tests seem to be baseline. I see that other PRs are also failing the same tests. Please let me know if it is fixed, I will sync to the latest refpoint and re-trigger the run. On the other hand, if it is indeed a known issue, could you please help merge this PR? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Feb 1, 2022
yxieca
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Feb 1, 2022
Why I did it Fixes #8980 partly. The corresponding changes in sonic-sairedis is here : sonic-net/sonic-sairedis#975 How I did it Include changes from both repos and build an image for verification. How to verify it Trigger fast-reboot with the changes, see the attribute SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL being set at the SAI level. Signed-off-by: Thushar Gowda <[email protected]>
tbgowda
added a commit
to tbgowda/sonic-sairedis
that referenced
this pull request
Feb 2, 2022
…net#975) Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute for all platforms based on capability Signed-off-by: Thushar Gowda <[email protected]>
5 tasks
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Feb 8, 2022
Why I did it Fixes #8980 partly. The corresponding changes in sonic-sairedis is here : sonic-net/sonic-sairedis#975 How I did it Include changes from both repos and build an image for verification. How to verify it Trigger fast-reboot with the changes, see the attribute SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL being set at the SAI level. Signed-off-by: Thushar Gowda <[email protected]>
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
kcudnik
pushed a commit
that referenced
this pull request
May 13, 2022
Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute for all platforms based on capability Remove Mellanox specific checks Check whether the attribute is supported Call SAI API if it is supported, else ignore Cherry-picking #975
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
…net#975) Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute for all platforms based on capability Signed-off-by: Thushar Gowda <[email protected]>
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
…net#975) Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute for all platforms based on capability Signed-off-by: Thushar Gowda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute for all platforms based on capability
Test Done:
Tested with corresponding support in SAI to check if attribute is being set correctly.