Skip to content

fix: Fix resource acceptance tests setup part5#3514

Merged
sfc-gh-asawicki merged 30 commits into
devfrom
fix-resource-acceptance-tests-setup-part5
Apr 4, 2025
Merged

fix: Fix resource acceptance tests setup part5#3514
sfc-gh-asawicki merged 30 commits into
devfrom
fix-resource-acceptance-tests-setup-part5

Conversation

@sfc-gh-asawicki

@sfc-gh-asawicki sfc-gh-asawicki commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

Continuation of #3443, #3445, #3448, #3449, #3450, #3480, #3489, and #3504.

Use the pre-created database or create a database with the parameters set (resource - part, last):

  • the pre-created database not changed yet (it still does not have the parameters)
  • going alphabetically through resources, all completed
  • remove database from setups where not needed
  • add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t)
  • generate shared database resource config builder

Next PRs:

  • pre-created database changes
  • fix a few failing tests from different runs
  • follow-up for the problematic ones

@github-actions

github-actions Bot commented Apr 4, 2025

Copy link
Copy Markdown

Integration tests failure for 68b8aa92c182286ab3d3add4c745fb2e359ef854

Comment thread pkg/resources/shared_database_acceptance_test.go
@sfc-gh-asawicki sfc-gh-asawicki merged commit 45abb78 into dev Apr 4, 2025
@sfc-gh-asawicki sfc-gh-asawicki deleted the fix-resource-acceptance-tests-setup-part5 branch April 4, 2025 15:36
sfc-gh-asawicki added a commit that referenced this pull request Apr 7, 2025
Continuation of
#3443,
#3445,
#3448,
#3449,
#3450,
#3480,
#3489,
#3504,
and
#3514.

- change the pre-created database (set parameters)
- fix a few failing tests from different runs
- replace external providers setup with the existing function

Next PRs:
- follow-up for the problematic tests

@sfc-gh-jmichalak sfc-gh-jmichalak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Required: true,
ForceNew: true,
Description: "The fully qualified name (`database.schema.table`) of the table to apply the masking policy to.",
DiffSuppressFunc: suppressIdentifierQuoting,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it's a tiny thing, but we should mention this in the migration guide.

column {
name = "column1"
type = "VARCHAR(16)"
masking_policy = "\"%s\".\"%s\".\"%s\""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we can use maskingPolicyId.FullyQualifiedName here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants