fix: Fix resource acceptance tests setup part3#3489
Merged
Conversation
…8 user integration test
|
Integration tests failure for 5a8b24a3bc032147e11e64527cec5d21be223b93 |
|
Integration tests success for c92af41dd7f4a55d4fe279c4ac44ade362404dad |
sfc-gh-jcieslak
approved these changes
Mar 28, 2025
| }, | ||
| }, | ||
| PreConfig: func() { | ||
| func() { acc.UnsetConfigPathEnv(t) }() |
Contributor
There was a problem hiding this comment.
Nit: this nesting is not needed.
Contributor
Author
There was a problem hiding this comment.
Fixed in part5
Contributor
Author
There was a problem hiding this comment.
Done in follow-up
sfc-gh-asawicki
added a commit
that referenced
this pull request
Apr 2, 2025
Continuation of #3443, #3445, #3448, #3449, #3450, #3480, and #3489. Use the pre-created database or create a database with the parameters set (resource - part4): - the pre-created database not changed yet (it still does not have the parameters) - going alphabetically through resources, last one was secondary database - remove database from setups where not needed - add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t) Next PRs: - resources continuation (1 more PR est.) - pre-created database changes - follow-up for the problematic ones
sfc-gh-asawicki
added a commit
that referenced
this pull request
Apr 4, 2025
Continuation of #3443, #3445, #3448, #3449, #3450, #3480, #3489, and #3504. Use the pre-created database or create a database with the parameters set (resource - part, last): - the pre-created database not changed yet (it still does not have the parameters) - going alphabetically through resources, all completed - remove database from setups where not needed - add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t) - generate shared database resource config builder Next PRs: - pre-created database changes - fix a few failing tests from different runs - follow-up for the problematic ones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #3443, #3445, #3448, #3449, #3450, and #3480.
Use the pre-created database or create a database with the parameters set (resource - part3):
TestAcc_User_handleChangesToDefaultSecondaryRolesskipped for now (next PR)TestAcc_User_migrateFromVersion094_noDefaultSecondaryRolesSetremoved completely because of lack of way to set it up with current "ALL" default and 0.94.1 version of the provider not allowing to set it up through resourceError: 098519 (22023): Empty network policy [id] cannot be active.)Next PRs: