fix: Fix resource acceptance tests setup part4#3504
Merged
Conversation
|
Integration tests success for 3d43f2ea1f5f5ea183a1aeb7b41a313ff8646f84 |
sfc-gh-jmichalak
approved these changes
Apr 2, 2025
| resource.TestCheckResourceAttr("snowflake_schema.test", "show_output.0.comment", ""), | ||
| resource.TestCheckResourceAttr("snowflake_schema.test", "show_output.0.options", ""), | ||
| resource.TestCheckResourceAttr(basicSchemaModel.ResourceReference(), "name", id.Name()), | ||
| resource.TestCheckResourceAttr(basicSchemaModel.ResourceReference(), "database", acc.TestDatabaseName), |
Contributor
There was a problem hiding this comment.
Nit: why acc.TestDatabaseName here?
sfc-gh-jcieslak
approved these changes
Apr 2, 2025
sfc-gh-asawicki
added a commit
that referenced
this pull request
Apr 4, 2025
Continuation of #3443, #3445, #3448, #3449, #3450, #3480, #3489, and #3504. Use the pre-created database or create a database with the parameters set (resource - part, last): - the pre-created database not changed yet (it still does not have the parameters) - going alphabetically through resources, all completed - remove database from setups where not needed - add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t) - generate shared database resource config builder Next PRs: - pre-created database changes - fix a few failing tests from different runs - follow-up for the problematic ones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #3443, #3445, #3448, #3449, #3450, #3480, and #3489.
Use the pre-created database or create a database with the parameters set (resource - part4):
Next PRs: