Skip to content

fix: Fix resource acceptance tests setup part2#3480

Merged
sfc-gh-asawicki merged 5 commits into
devfrom
fix-resource-acceptance-tests-setup-part2
Mar 27, 2025
Merged

fix: Fix resource acceptance tests setup part2#3480
sfc-gh-asawicki merged 5 commits into
devfrom
fix-resource-acceptance-tests-setup-part2

Conversation

@sfc-gh-asawicki

@sfc-gh-asawicki sfc-gh-asawicki commented Mar 26, 2025

Copy link
Copy Markdown
Contributor

Continuation of #3443, #3445, #3448, #3449, and #3450.

Use the pre-created database or create a database with the parameters set (resource - part2):

  • the pre-created database not changed yet (it still does not have the parameters)
  • going alphabetically through resources, last one was grant privileges to database role
  • remove database from setups where not needed
  • add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t)
  • renamed database client method for database with parameters
  • added helper method to the database client helper

Next PRs:

  • resources continuation (1 more PR est.)
  • pre-created database changes
  • follow-up for the problematic ones

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review March 26, 2025 11:01
@github-actions

Copy link
Copy Markdown

Integration tests failure for e63a987028daae32f32ae7c3ec43c43ef686ab64

Comment thread pkg/acceptance/helpers/database_client.go
@sfc-gh-asawicki sfc-gh-asawicki merged commit f61051a into dev Mar 27, 2025
@sfc-gh-asawicki sfc-gh-asawicki deleted the fix-resource-acceptance-tests-setup-part2 branch March 27, 2025 10:18
sfc-gh-asawicki added a commit that referenced this pull request Mar 28, 2025
Continuation of
#3443,
#3445,
#3448,
#3449,
#3450,
and
#3480.

Use the pre-created database or create a database with the parameters
set (resource - part3):
- the pre-created database not changed yet (it still does not have the
parameters)
- going alphabetically through resources, last one was oauth integration
for partner applications
- remove database from setups where not needed
- add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t)
- adjust tests after BCR 2024_08 general availability
  - secondary roles
  - defaults in users
  - managed account show changes
  - sync_password default change in scim
- `TestAcc_User_handleChangesToDefaultSecondaryRoles` skipped for now
(next PR)
- `TestAcc_User_migrateFromVersion094_noDefaultSecondaryRolesSet`
removed completely because of lack of way to set it up with current
"ALL" default and 0.94.1 version of the provider not allowing to set it
up through resource
- some tests started to fail because of the secondary roles default on
the CI user - changed it back to empty
- adjust to changes in validation of network policy (`Error: 098519
(22023): Empty network policy [id] cannot be active.`)
- adjust changes in validation for network rules addition (ENGRESS ->
INGRESS changes in tests)
- merge two upgrader helper files

Next PRs:
- resources continuation (1 more PR est.)
- pre-created database changes
- follow-up for the problematic ones
sfc-gh-asawicki added a commit that referenced this pull request Apr 2, 2025
Continuation of
#3443,
#3445,
#3448,
#3449,
#3450,
#3480,
and
#3489.

Use the pre-created database or create a database with the parameters
set (resource - part4):
- the pre-created database not changed yet (it still does not have the
parameters)
- going alphabetically through resources, last one was secondary
database
- remove database from setups where not needed
- add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t)

Next PRs:
- resources continuation (1 more PR est.)
- pre-created database changes
- follow-up for the problematic ones
sfc-gh-asawicki added a commit that referenced this pull request Apr 4, 2025
Continuation of
#3443,
#3445,
#3448,
#3449,
#3450,
#3480,
#3489,
and
#3504.

Use the pre-created database or create a database with the parameters
set (resource - part, last):
- the pre-created database not changed yet (it still does not have the
parameters)
- going alphabetically through resources, all completed
- remove database from setups where not needed
- add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t)
- generate shared database resource config builder

Next PRs:
- pre-created database changes
- fix a few failing tests from different runs
- follow-up for the problematic ones
sfc-gh-asawicki added a commit that referenced this pull request Apr 7, 2025
Continuation of
#3443,
#3445,
#3448,
#3449,
#3450,
#3480,
#3489,
#3504,
and
#3514.

- change the pre-created database (set parameters)
- fix a few failing tests from different runs
- replace external providers setup with the existing function

Next PRs:
- follow-up for the problematic tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants