Skip to content

fix: Fix datasource acceptance tests setup part4#3449

Merged
sfc-gh-asawicki merged 30 commits into
devfrom
fix-datasource-acceptance-tests-setup-part4
Mar 18, 2025
Merged

fix: Fix datasource acceptance tests setup part4#3449
sfc-gh-asawicki merged 30 commits into
devfrom
fix-datasource-acceptance-tests-setup-part4

Conversation

@sfc-gh-asawicki

@sfc-gh-asawicki sfc-gh-asawicki commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Continuation of #3443, #3445, and #3448.

Use the pre-created database or create a database with the parameters set (part 4):

  • the pre-created database not changed yet (it still does not have the parameters)
  • going alphabetically, datasources finished
  • generate model builders for Streamlit resource
  • generate model builders for Streamlits, Streams, Tags, Tasks, Users, Views, and Warehouses datasources
  • remove file setups when unnecessary (do not migrate the ones with complex multiresource setups)
  • add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t)
  • do not add the builders for non-stable datasources
  • address issues from the previous review
  • expect AAD_PROVISIONER role at test setup
  • change default connection helper constructor

Next PRs:

  • resources
  • pre-created database changes

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review March 17, 2025 23:14
@github-actions

github-actions Bot commented Mar 18, 2025

Copy link
Copy Markdown

Integration tests failure for 6eeda64aae512732e32db28e490be949beed25d4

@sfc-gh-asawicki sfc-gh-asawicki mentioned this pull request Mar 18, 2025
Merged
Base automatically changed from fix-datasource-acceptance-tests-setup-part3 to dev March 18, 2025 11:25
@sfc-gh-asawicki
part 4 starts here
26205ae
@sfc-gh-asawicki
Fix sequences datasource acceptance test setup
d0f7aa3
@sfc-gh-asawicki
Fix shares datasource acceptance test setup
80a82ea
@sfc-gh-asawicki
Fix stages datasource acceptance test setup
00ea8a4
@sfc-gh-asawicki
Fix storage integrations datasource acceptance test setup
0feded9
@sfc-gh-asawicki
Generate streamlit resource model builder
a9d1573
@sfc-gh-asawicki
Generate streamlit datasource model builder
427d63a
@sfc-gh-asawicki
Fix streamlits datasource acceptance tests setup
ef9d0fa
@sfc-gh-asawicki
Generate streams datasource model builder
353eab2
@sfc-gh-asawicki
Fix streams datasource acceptance test setup (part1)
227094b
@sfc-gh-asawicki
Fix streams datasource acceptance test setup (part2)
1f78d17
@sfc-gh-asawicki
Fix streams datasource acceptance test setup (part3 - last)
0b0e580
@sfc-gh-asawicki
Fix generate scim access token acceptance test
37b2b99
@sfc-gh-asawicki
Fix secondary connection acceptance test
4f4adad
@sfc-gh-asawicki
Fix the rest of system functions data sources acceptance tests
86c9972
@sfc-gh-asawicki
Fix tables datasource acceptance test setup
ae37b69
@sfc-gh-asawicki
Generate tags datasource model builder
77ad908
@sfc-gh-asawicki
Fix tags datasource acceptance test setup
70b87bd
@sfc-gh-asawicki
Generate tasks datasource model builder
562b3cd
@sfc-gh-asawicki
Set up tasks datasource acceptance tests with config builders (part1)
37a6999
@sfc-gh-asawicki
Set up tasks datasource acceptance tests with config builders (part2)
94c9e07
@sfc-gh-asawicki sfc-gh-asawicki force-pushed the fix-datasource-acceptance-tests-setup-part4 branch from 6eeda64 to 7155edf Compare March 18, 2025 11:31
@sfc-gh-asawicki sfc-gh-asawicki merged commit 935d969 into dev Mar 18, 2025
@sfc-gh-asawicki sfc-gh-asawicki deleted the fix-datasource-acceptance-tests-setup-part4 branch March 18, 2025 11:32
@sfc-gh-asawicki sfc-gh-asawicki mentioned this pull request Mar 18, 2025
Merged
sfc-gh-jmichalak pushed a commit that referenced this pull request Mar 24, 2025
@sfc-gh-asawicki @sfc-gh-jmichalak
fix: Fix datasource acceptance tests setup part4 (#3449)
04e082a 
Continuation of
#3443,
#3445,
and
#3448.

Use the pre-created database or create a database with the parameters
set (part 4):
- the pre-created database not changed yet (it still does not have the
parameters)
- going alphabetically, datasources finished
- generate model builders for Streamlit resource
- generate model builders for Streamlits, Streams, Tags, Tasks, Users,
Views, and Warehouses datasources
- remove file setups when unnecessary (do not migrate the ones with
complex multiresource setups)
- add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t)
- do not add the builders for non-stable datasources
- address issues from the previous review
- expect AAD_PROVISIONER role at test setup
- change default connection helper constructor

Next PRs:
- resources
- pre-created database changes
@snowflake-release-please snowflake-release-please Bot mentioned this pull request Mar 24, 2025
Merged
sfc-gh-jmichalak pushed a commit that referenced this pull request Mar 25, 2025
@snowflake-release-please
chore(main): release 1.0.5 (#3463)
3f8e4a2 
🤖 I have created a release *beep* *boop*
---


##
[1.0.5](v1.0.4...v1.0.5)
(2025-03-25)


### 🔧 **Misc**

* Bump tracking version to v1.0.5
([#3460](#3460))
([2af79e6](2af79e6))
* Bump tracking version to v1.0.5
([#3460](#3460))
([3aaf555](3aaf555))
* Document godebug flag usage
([#3429](#3429))
([5f04947](5f04947))
* Document godebug flag usage
([#3429](#3429))
([2dce172](2dce172))
* fix failing tests
([#3428](#3428))
([884ca54](884ca54))
* fix failing tests
([#3428](#3428))
([245fd86](245fd86))
* Fix migration guide
([#3468](#3468))
([6540841](6540841))
* GitHub actions cleanup
([#3431](#3431))
([1cc6d80](1cc6d80))
* GitHub actions cleanup
([#3431](#3431))
([a6e7429](a6e7429))
* Protect pentesting user and role from sweepers
([#3426](#3426))
([1478c5e](1478c5e))
* Protect pentesting user and role from sweepers
([#3426](#3426))
([6354dba](6354dba))
* Remove driver instrumentation
([#3439](#3439))
([61802a8](61802a8))
* Remove driver instrumentation
([#3439](#3439))
([e9fc6ed](e9fc6ed))
* Remove SF_TF_ADDITIONAL_DEBUG_LOGGING
([#3441](#3441))
([cab63e9](cab63e9))
* Remove SF_TF_ADDITIONAL_DEBUG_LOGGING
([#3441](#3441))
([b57db81](b57db81))
* Update GitHub actions
([#3455](#3455))
([3b027a8](3b027a8))
* Update GitHub actions
([#3455](#3455))
([368f090](368f090))
* Use environmental secrets in GitHub Actions
([#3440](#3440))
([6048977](6048977))
* Use environmental secrets in GitHub Actions
([#3440](#3440))
([8e5a262](8e5a262))


### 🐛 **Bug fixes:**

* Add boolean env validations and unit tests for TOML config validation
([#3453](#3453))
([c113928](c113928))
* Add boolean env validations and unit tests for TOML config validation
([#3453](#3453))
([408db4e](408db4e))
* Adjust docs
([#3451](#3451))
([46d071d](46d071d))
* Adjust docs
([#3451](#3451))
([29b0e4d](29b0e4d))
* Apply new assertions setup
([#3409](#3409))
([e5fdced](e5fdced))
* Apply new assertions setup
([#3409](#3409))
([af83da0](af83da0))
* Correct a typo in a tag resource example
([#3446](#3446))
([a0202d1](a0202d1))
* Correct a typo in a tag resource example
([#3446](#3446))
([afd19a2](afd19a2))
* Fix datasource acceptance tests setup part1
([#3443](#3443))
([58126ea](58126ea))
* Fix datasource acceptance tests setup part1
([#3443](#3443))
([5046654](5046654))
* Fix datasource acceptance tests setup part2
([#3445](#3445))
([6c7ceeb](6c7ceeb))
* Fix datasource acceptance tests setup part2
([#3445](#3445))
([4ba2bb6](4ba2bb6))
* Fix datasource acceptance tests setup part3
([#3448](#3448))
([5475c69](5475c69))
* Fix datasource acceptance tests setup part3
([#3448](#3448))
([f6fdc17](f6fdc17))
* Fix datasource acceptance tests setup part4
([#3449](#3449))
([04e082a](04e082a))
* Fix datasource acceptance tests setup part4
([#3449](#3449))
([935d969](935d969))
* Fix tasks tests
([#3434](#3434))
([33ab740](33ab740))
* Fix tasks tests
([#3434](#3434))
([b5457f6](b5457f6))
* Handle TOML file permissions
([#3444](#3444))
([6c746b4](6c746b4))
* Handle TOML file permissions
([#3444](#3444))
([e4ed171](e4ed171))
* Limit TOML file size
([#3432](#3432))
([55fcbe3](55fcbe3))
* Limit TOML file size
([#3432](#3432))
([2e12981](2e12981))
* Quick fix assertions
([#3438](#3438))
([0e05c6f](0e05c6f))
* Quick fix assertions
([#3438](#3438))
([a430ba7](a430ba7))
* Skip file permission verification by default
([#3476](#3476))
([562173d](562173d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
sfc-gh-asawicki added a commit that referenced this pull request Mar 25, 2025
@sfc-gh-asawicki
fix: Fix resource acceptance tests setup part1 (#3450)
3ff4ba5 
Continuation of
#3443,
#3445,
#3448,
and
#3449.

Use the pre-created database or create a database with the parameters
set (resource - part1):
- the pre-created database not changed yet (it still does not have the
parameters)
- going alphabetically through resources, last one was grant ownership
- generate model builders for AccountRole resource
- remove file setups when unnecessary (do not migrate the ones with
complex multiresource setups)
- remove database from setups where not needed
- add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t)
- do not add the builders for non-stable datasources
- skip tests in the database resource and in
external_oauth_integration_acceptance_test.go (follow-up needed for
these to discuss and address all the nondeterministic tests)
- remove tests for parameters that can be set on other level than
account (in pkg/resources/account_parameter_acceptance_test.go)

Next PRs:
- resources continuation (1 or 2 more PRs)
- pre-created database changes
- follow-up for the problematic ones
@sfc-gh-asawicki sfc-gh-asawicki mentioned this pull request Mar 26, 2025
Merged
sfc-gh-asawicki added a commit that referenced this pull request Mar 27, 2025
@sfc-gh-asawicki
fix: Fix resource acceptance tests setup part2 (#3480)
f61051a 
Continuation of
#3443,
#3445,
#3448,
#3449,
and
#3450.

Use the pre-created database or create a database with the parameters
set (resource - part2):
- the pre-created database not changed yet (it still does not have the
parameters)
- going alphabetically through resources, last one was grant privileges
to database role
- remove database from setups where not needed
- add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t)
- renamed database client method for database with parameters
- added helper method to the database client helper

Next PRs:
- resources continuation (1 more PR est.)
- pre-created database changes
- follow-up for the problematic ones
@sfc-gh-asawicki sfc-gh-asawicki mentioned this pull request Mar 27, 2025
Merged
sfc-gh-asawicki added a commit that referenced this pull request Mar 28, 2025
@sfc-gh-asawicki
fix: Fix resource acceptance tests setup part3 (#3489)
12f6ca0 
Continuation of
#3443,
#3445,
#3448,
#3449,
#3450,
and
#3480.

Use the pre-created database or create a database with the parameters
set (resource - part3):
- the pre-created database not changed yet (it still does not have the
parameters)
- going alphabetically through resources, last one was oauth integration
for partner applications
- remove database from setups where not needed
- add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t)
- adjust tests after BCR 2024_08 general availability
  - secondary roles
  - defaults in users
  - managed account show changes
  - sync_password default change in scim
- `TestAcc_User_handleChangesToDefaultSecondaryRoles` skipped for now
(next PR)
- `TestAcc_User_migrateFromVersion094_noDefaultSecondaryRolesSet`
removed completely because of lack of way to set it up with current
"ALL" default and 0.94.1 version of the provider not allowing to set it
up through resource
- some tests started to fail because of the secondary roles default on
the CI user - changed it back to empty
- adjust to changes in validation of network policy (`Error: 098519
(22023): Empty network policy [id] cannot be active.`)
- adjust changes in validation for network rules addition (ENGRESS ->
INGRESS changes in tests)
- merge two upgrader helper files

Next PRs:
- resources continuation (1 more PR est.)
- pre-created database changes
- follow-up for the problematic ones
@sfc-gh-asawicki sfc-gh-asawicki mentioned this pull request Apr 1, 2025
Merged
sfc-gh-asawicki added a commit that referenced this pull request Apr 2, 2025
@sfc-gh-asawicki
fix: Fix resource acceptance tests setup part4 (#3504)
6a3b69c 
Continuation of
#3443,
#3445,
#3448,
#3449,
#3450,
#3480,
and
#3489.

Use the pre-created database or create a database with the parameters
set (resource - part4):
- the pre-created database not changed yet (it still does not have the
parameters)
- going alphabetically through resources, last one was secondary
database
- remove database from setups where not needed
- add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t)

Next PRs:
- resources continuation (1 more PR est.)
- pre-created database changes
- follow-up for the problematic ones
@sfc-gh-asawicki sfc-gh-asawicki mentioned this pull request Apr 4, 2025
Merged
sfc-gh-asawicki added a commit that referenced this pull request Apr 4, 2025
@sfc-gh-asawicki
fix: Fix resource acceptance tests setup part5 (#3514)
45abb78 
Continuation of
#3443,
#3445,
#3448,
#3449,
#3450,
#3480,
#3489,
and
#3504.

Use the pre-created database or create a database with the parameters
set (resource - part, last):
- the pre-created database not changed yet (it still does not have the
parameters)
- going alphabetically through resources, all completed
- remove database from setups where not needed
- add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t)
- generate shared database resource config builder

Next PRs:
- pre-created database changes
- fix a few failing tests from different runs
- follow-up for the problematic ones
@sfc-gh-asawicki sfc-gh-asawicki mentioned this pull request Apr 6, 2025
Merged
sfc-gh-asawicki added a commit that referenced this pull request Apr 7, 2025
@sfc-gh-asawicki
fix: Change setup for precreated objects in acceptance tests (#3515)
0b76012 
Continuation of
#3443,
#3445,
#3448,
#3449,
#3450,
#3480,
#3489,
#3504,
and
#3514.

- change the pre-created database (set parameters)
- fix a few failing tests from different runs
- replace external providers setup with the existing function

Next PRs:
- follow-up for the problematic tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-asawicki @sfc-gh-jcieslak @sfc-gh-jmichalak