Repository navigation
[Refactor][TCPCG] Bind live forward batches in BCG eager calls (2/9) - #42286
Merged
Oasis-Git merged 8 commits intoOct 8, 2026
Merged
Conversation
Oasis-Git
requested review from
1am9trash,
Fridge003,
HaiShaw,
YAMY1234,
Ying1123,
hebiao064,
hnyls2002,
hubertlu-tw,
ispobock,
kkHuang-amd,
merrymercy and
rainj-me
as code owners
October 2, 2026 23:21
This was referenced Oct 2, 2026
Collaborator
Author
|
CI pass with one known fail: https://github.com/sgl-project/sglang/actions/runs/37548288530 |
Collaborator
Author
|
Fix by #42768 |
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is step 2/9, split from the original TCPCG removal PR #41634.
Step 1 (#42285) is merged. Upstream
mainwas merged into this branch with a normal merge commit (no history rewrite). The Files changed tab now contains only step 2: three files. Pre-commit and the eight CPU tests described below passed again on the merged tree; upstream CI must validate the updated head.BCG eager calls currently retain their capture-time arguments. To let later migrations pass
forward_batchdirectly, replay must supply the prepared serving batch instead of retaining the capture batch. This PR adds that binding while preserving the existing decorator forms for callers migrated in later steps.Series
Only steps 1 and 2 are submitted upstream so far. Later steps will be submitted after review. The disputed relocation of inactive compiler/reference files is excluded pending a separate decision.
Changes
@eager_on_graphon functions and methods, including methods with a namedforward_batchargument.static_forward_batchfrom the BCG backend into replay.eager_on_graph(True),enable=True/False, and the existing capture-stub form so unmigrated callers continue to work.No backend is retired in this step. Callers without a named
forward_batchretain their existing argument behavior.Validation
CI States
Latest PR Test (Base): ❌ Run #37548288530
Latest PR Test (Extra): ❌ Run #37548288241
Latest PR Test (AMD ROCm 10): ❌ Run #37548288542