Repository navigation
Conversation
Oasis-Git
requested review from
1am9trash,
BBuf,
Edwardf0t1,
Fridge003,
HaiShaw,
JustinTong0323,
Qiaolin-Yu,
YAMY1234,
Ying1123,
ch-wan,
fzyzcjy,
hebiao064,
hnyls2002,
hubertlu-tw,
ispobock,
kkHuang-amd,
merrymercy,
ping1jing2,
rainj-me,
sogalin,
wisclmy0611 and
zijiexia
as code owners
October 2, 2026 23:24
This was referenced Oct 2, 2026
Oasis-Git
force-pushed
the
refactor/tcpcg-04-attention-eager
branch
from
October 11, 2026 04:22
c5cabe3 to
fed12ee
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is step 4/9, split from the original TCPCG removal PR #41634.
Steps 1–3 are merged. Rebased onto upstream
main(58cb1a2be6); the PR now contains only step 4 as one commit. Review the step-4 files.Replace attention's TCPCG split-op adapters and layer-registry lookups with class-owned eager methods. On BCG replay, these methods read the live prepared batch through
get_forward_batch()from step 2's runner-owned scope. The eager decorator and replay callbacks do not capture or rebind a batch argument.Series
Changes
RadixAttention._eager_attention. Preserve main’s sparse-BCG fix: sparse attention also runs in an eager region and reads the live batch during replay.attention/graph_utils.py. Preserve the newer eager padded-extend handling, including independent query/KV extents and tuple outputs.ForwardContextunchanged. Publish the full-prefill flag and raw token count in a separate runner-ownedprefill_graph_scope, with restoration on exit.The legacy TCPCG context and layer registries remain temporarily for unmigrated callers until step 8. This changes attention dispatch and eager replay, while preserving backend computation and graph-owned output buffers.
Validation
python file.py -f): 24 passed under the same shim.CI States
Latest PR Test (Base): ❌ Run #38111399643
Latest PR Test (Extra): ❌ Run #38111399479
Latest PR Test (AMD ROCm 10): ❌ Run #38111399624