Repository navigation
Conversation
Oasis-Git
requested review from
AniZpZ,
BBuf,
Edwardf0t1,
FlamingoPg,
Fridge003,
HaiShaw,
Ying1123,
adarshxs,
alexnails,
ch-wan,
fzyzcjy,
hnyls2002,
ispobock,
merrymercy,
ping1jing2 and
whybeyoung
as code owners
October 2, 2026 23:31
Oasis-Git
requested review from
AgainstEntropy,
Qiaolin-Yu,
YAMY1234,
hebiao064,
hubertlu-tw,
kevin-mii,
kkHuang-amd,
mickqian,
niehen6174,
rainj-me,
wisclmy0611,
yichiche,
yizhang2077 and
yuan-luo
as code owners
October 2, 2026 23:31
Oasis-Git
requested review from
JustinTong0323,
sogalin and
zijiexia
as code owners
October 2, 2026 23:31
This was referenced Oct 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is step 9/9, split from the original TCPCG removal PR #41634.
Depends on #42292 (8/9); merge those dependencies first. This branch targets upstream
main, so its diff includes unmerged prerequisites. Review this step alone using the isolated step-9 diff.Series
The disputed relocation of inactive compiler/reference files is excluded pending a separate decision.
Changes
Remove TCPCG-specific quantization indirection after the runtime migration.
Keep this change separate because removing opaque custom-op boundaries can affect torch.compile behavior. This PR does not remove the torch.compile framework.
The cumulative series matches the original refactor except for the deliberately excluded reference-folder relocation. Inactive TCPCG files remain at their original paths; the final-tree scan found no imports of them from active Python code.
Validation
Pre-commit and Python syntax checks passed. The final combined CPU suite passed 68 tests plus 16 subtests using the macOS import shim. Those tests do not validate quantization kernels or their torch.compile behavior: GPU quantization, compilation, model accuracy, and upstream CI remain to be validated.
CI States
Latest PR Test (Base): ❌ Missing
run-cilabel -- add it to run CI tests.Latest PR Test (Extra): ❌ Blocked --
run-ciis required first.Latest PR Test (AMD ROCm 10): ➖ No AMD PR run found for this commit.