Repository navigation
Conversation
Oasis-Git
requested review from
1am9trash,
AgainstEntropy,
BBuf,
Fridge003,
HaiShaw,
YAMY1234,
Ying1123,
hebiao064,
hnyls2002,
hubertlu-tw,
ispobock,
kevin-mii,
kkHuang-amd,
merrymercy,
mickqian,
niehen6174,
ping1jing2,
rainj-me and
yichiche
as code owners
October 2, 2026 23:31
This was referenced Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is step 7/9, split from the original TCPCG removal PR #41634.
Depends on #42286 (2/9); merge those dependencies first. This branch targets upstream
main, so its diff includes unmerged prerequisites. Review this step alone using the isolated step-7 diff.Series
The disputed relocation of inactive compiler/reference files is excluded pending a separate decision.
Changes
Migrate diffusion attention and MiniMax H3 wrappers to bare
@eager_on_graphand consistently named_eager_functions. Preserve tuple boxing and the existing graph-dispatch behavior.This is the independent diffusion slice: it depends only on the eager API introduced in step 2, not the SRT caller migrations in steps 3–6.
Validation
Pre-commit and Python syntax checks passed on the changed files. Diffusion CUDA execution and upstream CI remain to be validated; the local development machine is macOS.
CI States
Latest PR Test (Base): ❌ Run #37077968419
Latest PR Test (Extra): ❌ Run #37077968211
Latest PR Test (AMD ROCm 10): ❌ Run #37077968500