Conversation
Co-authored-by: DarkSharpness <76582120+DarkSharpness@users.noreply.github.com> Co-authored-by: Xiaoyu Zhang <1182563586@qq.com> Co-authored-by: Mick <mickjagger19@icloud.com> Co-authored-by: Yuhao Yang <47235274+yhyang201@users.noreply.github.com> Co-authored-by: Cheng Wan <54331508+ch-wan@users.noreply.github.com> Co-authored-by: Ke Bao <ispobaoke@gmail.com> Co-authored-by: Baizhou Zhang <sobereddiezhang@gmail.com> Co-authored-by: Chunan Zeng <zcnrex@gmail.com> Co-authored-by: Khoa Pham <khoa.pham@radixark.ai> Co-authored-by: Ziyi Xu <ziyi.xu@radixark.ai> Co-authored-by: Zijie Xia <37504505+zijiexia@users.noreply.github.com> Co-authored-by: Yuwei An <ayw.sirius19@gmail.com> Co-authored-by: zhangxiaohao <1024393531@qq.com> Co-authored-by: Yangmin Li <yangminl@nvidia.com> Co-authored-by: Julien Lin <jullin@nvidia.com> Co-authored-by: Hao Phan <htphan@nvidia.com> Co-authored-by: Thomas Wang <1am9trash@gmail.com> Co-authored-by: RolaoDenthu <xinyisong0111@gmail.com> Co-authored-by: pigeonsoup <32922982+pigeonsoup@users.noreply.github.com> Co-authored-by: HaiShaw <hixiao@gmail.com> Co-authored-by: Xinyuan Tong <115166877+JustinTong0323@users.noreply.github.com> Co-authored-by: Pranjal Shankhdhar <pranjal.ssh@gmail.com> Co-authored-by: Lee Nau <lee.nau@gmail.com> Co-authored-by: HMING <126185151+Hearum@users.noreply.github.com> Co-authored-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Results for 🚀 |
|
/rerun-test test_mxfp4_sm90_cutlass.py |
|
Results for 🚀 |
|
/rerun-test test/registered/models_e2e/test_dsa_glm52_hisparse.py |
|
Results for 🚀 |
|
Hi, I hit the following issue on mi355x: stdout:
[1/2] /opt/rocm-7.2.0/bin/hipcc -std=c++17 -O2 -fPIC -D__HIP_PLATFORM_AMD__=1 -fno-gpu-rdc --offload-arch=gfx950 -DUSE_ROCM -std=c++20 -O3 -DHIP_FP8_TYPE_E4M3=1 -I/opt/venv/lib/python3.10/site-packages/tvm_ffi/include -I/opt/venv/lib/python3.10/site-packages/tvm_ffi/include -I/opt/rocm-7.2.0/include -I/billhe/sglang-k3-day0/python/sglang/kernels/jit/include -c /root/.cache/tvm-ffi/sgl_kernel_jit_kimi_k3_situ_and_mul_bf16_t_false_926fca12de2a1a77__arch_9.5__tvmffi_0.5.16.dev20260802+g0877a0e2f1/cuda.cu -o cuda_0.o
FAILED: [code=1] cuda_0.o
/opt/rocm-7.2.0/bin/hipcc -std=c++17 -O2 -fPIC -D__HIP_PLATFORM_AMD__=1 -fno-gpu-rdc --offload-arch=gfx950 -DUSE_ROCM -std=c++20 -O3 -DHIP_FP8_TYPE_E4M3=1 -I/opt/venv/lib/python3.10/site-packages/tvm_ffi/include -I/opt/venv/lib/python3.10/site-packages/tvm_ffi/include -I/opt/rocm-7.2.0/include -I/billhe/sglang-k3-day0/python/sglang/kernels/jit/include -c /root/.cache/tvm-ffi/sgl_kernel_jit_kimi_k3_situ_and_mul_bf16_t_false_926fca12de2a1a77__arch_9.5__tvmffi_0.5.16.dev20260802+g0877a0e2f1/cuda.cu -o cuda_0.o
In file included from /root/.cache/tvm-ffi/sgl_kernel_jit_kimi_k3_situ_and_mul_bf16_t_false_926fca12de2a1a77__arch_9.5__tvmffi_0.5.16.dev20260802+g0877a0e2f1/cuda.cu:7:
/billhe/sglang-k3-day0/python/sglang/kernels/jit/csrc/kimi_k3/situ_and_mul.cuh:21:10: fatal error: 'cuda_fp8.h' file not found
21 | #include <cuda_fp8.h>
| ^~~~~~~~~~~~
1 error generated when compiling for gfx950.
failed to execute:/opt/rocm-7.2.0/lib/llvm/bin/clang++ --offload-arch=gfx950 -std=c++17 -O2 -fPIC -D__HIP_PLATFORM_AMD__=1 -fno-gpu-rdc -DUSE_ROCM -std=c++20 -O3 -DHIP_FP8_TYPE_E4M3=1 -I/opt/venv/lib/python3.10/site-packages/tvm_ffi/include -I/opt/venv/lib/python3.10/site-packages/tvm_ffi/include -I/opt/rocm-7.2.0/include -I/billhe/sglang-k3-day0/python/sglang/kernels/jit/include -c -x hip /root/.cache/tvm-ffi/sgl_kernel_jit_kimi_k3_situ_and_mul_bf16_t_false_926fca12de2a1a77__arch_9.5__tvmffi_0.5.16.dev20260802+g0877a0e2f1/cuda.cu -o "cuda_0.o"
ninja: build stopped: subcommand failed.A quick sample fix is : diff --git a/python/sglang/srt/layers/activation.py b/python/sglang/srt/layers/activation.py
index 837b766e74..06d1f1e3eb 100644
--- a/python/sglang/srt/layers/activation.py
+++ b/python/sglang/srt/layers/activation.py
@@ -208,6 +208,14 @@ class SituAndMul(MultiPlatformOp):
return situ_and_mul(x, None, self.beta, self.linear_beta)
+ # MultiPlatformOp.forward_hip defaults to forward_cuda, which JIT-builds
+ # kimi_k3/situ_and_mul.cuh; that header includes <cuda_fp8.h> and so cannot
+ # compile under hipcc. Introduced upstream by fb207b72b0 (#32890)
+ # Falling back to the native formula keeps K3 runnable here.
+ def forward_hip(self, x: torch.Tensor) -> torch.Tensor:
+ return self.forward_native(x)
+
def forward_cpu(self, x: torch.Tensor) -> torch.Tensor:
return self.forward_native(x)
cc @HaiShaw @billishyahao, @RolaoDenthu fixed it in #33447 |
|
/rerun-test test/registered/models_e2e/test_gpt_oss_4gpu_mxfp4.py |
|
Results for 🚀 🚀 |
Day-0 support for the Kimi K3 model.
Nvidia Support
Day 0 Cuda 13 image:
docker pull lmsysorg/sglang:kimi-k3Day 0 Cuda 12 image:
docker pull lmsysorg/sglang:kimi-k3-cu12AMD Support
Day 0 image:
docker pull lmsysorg/sglang-rocm:rocm720-mi35x-k3-20260727More details: #32548
Links
Cookbook: https://docs.sglang.io/cookbook/autoregressive/Moonshotai/Kimi-K3
Blog: https://www.lmsys.org/blog/2026-07-27-kimi-k3-day0-support
DSpark: https://huggingface.co/RadixArk/Kimi-K3-DSpark
Consolidated VLM follow-ups
This branch now absorbs #31318, #31581, #31587, #31637, #31638, and #31944. #31932 is superseded by the stronger
any(...)assertion already present on this branch.ValueErrorso the serving layer returns HTTP 400 without logging an expected tracebackPR-before vs PR-after performance
Projection packing microbenchmark, RTX 5090 BF16: 1/2/4/8 image chunks improved from 0.0242/0.0222/0.0231/0.0274 ms to 0.0140/0.0126/0.0126/0.0134 ms (1.73x-2.05x). This isolates the post-projector packing path.
CUDA IPC handle-cache A/B, 4x H100 TP4, Qwen3.6-35B-A3B-FP8 with four seeded random images per request:
The cache-off/cache-on runs used the same 512 MiB producer pool and had identical per-GPU memory after warmup (
69534 / 68076 / 68058 / 67578 MiB). CUDA IPC transport itself remains opt-in because its configured pool consumes HBM.Packed-grid metadata profiling on H200 TP8 removed all 12
Memcpy DtoHevents and reducedcudaStreamSynchronizefrom 60 to 48 for the measured request set. End-to-endbench_servingstayed within run-to-run noise, so this is a synchronization cleanup rather than a standalone throughput claim.MoonViT RoPE microbenchmark on NVIDIA B300 BF16 (16 heads, head dim 72); preparation is performed once per encoder forward and the table measures the per-layer Q/K operation:
The earlier H200 TP8 profile measured launch count 648 -> 108 and relevant GPU time -5.802 ms for the random-image request set; end-to-end serving remained within noise at that workload size.
Validation
git diff --checkpassRebasing Tracker
Merge 07/25 commits: 19ba402
Merge 07/26 commits: e7eec37
Merge 07/27 commits: 8a263bb
Merge 07/28 first half (to 9c0dbf): 9ef4c95
Merge 07/27 second half: b951c6b
Merge 07/29 first half (to e1f2f9d): b51f61f
Merge 07/29 second half: ac77803
Merge 07/31 (to e1964d): 49b58a0
CI States
Latest PR Test (Base): 🚫 Run #30932096634
Latest PR Test (Extra): ✅ Run #30950069784