Skip to content

[AMD] Fix Kimi-K3 SiTU JIT compile failure on ROCm - #33447

Merged
HaiShaw merged 1 commit into
sgl-project:kimi-k3from
RolaoDenthu:kimi-k3/fix-situ-compile-error
Aug 4, 2026
Merged

HaiShaw merged 1 commit into
sgl-project:kimi-k3from
RolaoDenthu:kimi-k3/fix-situ-compile-error

Conversation

@RolaoDenthu

@RolaoDenthu RolaoDenthu commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Motivation

The Kimi-K3 SiTU activation kernels cannot be JIT-compiled on ROCm.situ_and_mul.cuh includes <cuda_fp8.h> unconditionally, which is a CUDA-only header, so hipcc fails with:

/sgl-workspace/sglang/python/sglang/kernels/jit/csrc/kimi_k3/situ_and_mul.cuh:21:10: fatal error: 'cuda_fp8.h' file not found
   21 | #include <cuda_fp8.h>
      |          ^~~~~~~~~~~~
1 error generated when compiling for gfx950.

Modifications

Guard the <cuda_fp8.h> include with #ifndef USE_ROCM

Accuracy Tests

Speed Tests and Profiling

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

CI States

Latest PR Test (Base): ❌ Run #30865989327
Latest PR Test (Extra): ❌ Run #30865989193

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@HaiShaw
HaiShaw merged commit ba7b810 into sgl-project:kimi-k3 Aug 4, 2026
77 of 86 checks passed
@HaiShaw HaiShaw mentioned this pull request Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants