Conversation
bobcao3
requested review from
Qiaolin-Yu,
Ying1123,
hnyls2002,
merrymercy and
xiezhq-hermann
as code owners
August 1, 2026 14:31
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Author
|
/tag-and-rerun-ci |
…dices A PD decode bootstrap draft input built on a spec-less engine (or before the first overlap publish) carries future_indices=None; the relay path indexed it unconditionally. Return early, matching the existing zero-length guard one line below. (Reduced from the original DSPARK PD-disagg commit: the spec_info DSPARK branch and draft-KV transfer landed upstream via sgl-project#32541 and the DP/EP draft-batch fields via sgl-project#33098 — this guard is the only piece still missing on main.)
bobcao3
force-pushed
the
dspark-pd-disagg
branch
from
August 4, 2026 23:28
48ac3ed to
20d7817
Compare
Collaborator
|
/tag-and-rerun-ci |
Author
|
Turns out the DSPARK draft-KV transfer landed upstream already / is in some other PR that landed recently. |
This was referenced Aug 11, 2026
|
Follow-up regression coverage: #34410 pins the existing DSpark PD-decode draft-input handoff on current The new PR is test-only and does not duplicate the production support discussed here. It asserts the first-decode contract ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the DSPARK draft-KV transfer landed upstream already / is in some other PR that landed recently
Reduced from the original DSPARK PD-disagg commit: the spec_info
DSPARK branch and draft-KV transfer landed upstream via #32541 and the
DP/EP draft-batch fields via #33098, this one-line guard is the only piece
still missing on main.
Original PR body
Motivation
We are trying to bring up 4xB200 prefill + 4xB200 decode for Dsv4 flash 0731 (excellent model),
but with vanilla nightly we bumped into incompatibilities between DSPARK and PD-disagg (and file based HiCache).
Originally we went with #31466 but found that has incompatibility with HiCache,
after some inspection I think we can get this done with a much smaller set of changes presented here,
instead of the full hidden-row transfer system.
We have now a running setup on top of 07/31 nightly showing DSPARK with 3-5x improvement in single user case and KV cache seems to be functioning correctly.
Modifications
Two hunks make DSPARK work in PD disaggregation with symmetric TP:
To get a working setup:
--speculative-algorithm DSPARKruns DSparkWorkerV2._forward_prefill on every extend batch, building draft KV from target hidden states exactly like unified serving.--speculative-algorithm DSPARKmust be on both enginesHere is our full launch commands:
Prefill:
Decode:
Router:
CI States
Latest PR Test (Base): ❌ Run #30960127898
Latest PR Test (Extra): ❌ Run #30960127702