Conversation
There was a problem hiding this comment.
Code Review
This pull request fixes a logical bug in the assertion within verify_single_image_response where the string "person" was evaluated as a truthy value instead of checking its membership in text. The reviewer suggested improving the robustness of this check by making it case-insensitive.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # `driver` is for gemma-3-it | ||
| assert ( | ||
| "man" in text or "person" or "driver" in text | ||
| "man" in text or "person" in text or "driver" in text |
There was a problem hiding this comment.
To make the assertion more robust against variations in model capitalization (e.g., if the model starts the response with 'Man' or 'Person'), consider performing a case-insensitive check by converting text to lowercase.
| "man" in text or "person" in text or "driver" in text | |
| "man" in text.lower() or "person" in text.lower() or "driver" in text.lower() |
|
/tag-and-rerun-ci |
Summary
personbranch in the shared VLM single-image semantic check evaluate membership instead of a truthy string literaltest_vision_openai_serverfrom accepting responses that miss all person/man/driver conceptsValidation
python3 -m py_compile python/sglang/test/vlm_utils.pyorexpressions under the VLM test utilitiesCI States
Latest PR Test (Base): ⏳ Run #30347730447
Latest PR Test (Extra): ❌ Run #30347730327