Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
robbiemu
marked this pull request as ready for review
July 14, 2026 14:18
robbiemu
requested review from
BBuf,
Edwardf0t1,
Fridge003,
HaiShaw,
Ying1123,
ch-wan,
ispobock and
merrymercy
as code owners
July 14, 2026 14:18
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
2 tasks
Author
|
This probably should have been merged before #32541 . You can feel free to close it. Maybe there is a norm I'm not conforming to that my PRs get no review and the same code gets merged later? (Of course, I understand things slip through the cracks sometimes! Just want to make sure I understand if and when contributions are accepted) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nonesentinel from valid expert ID0in the static MXFP4 weight loader0Root cause
FusedMoE.weight_loaderusednot expert_idto detect an all-expert tensor. That condition is also true for expert ID0, so the loader entered the 3-D all-expert path and indexedloaded_weight.shape[2]on a 2-D per-expert tensor.This small fix is also present in the broader open #21529; this PR splits the loader correctness change and its regression test into an independently reviewable patch.
Impact
Static MXFP4 checkpoints loaded one expert at a time can fail while loading expert zero with
IndexError: tuple index out of range.Validation
python3 -m pytest -q test/registered/unit/layers/moe/test_mxfp4_expert_weight_loader.pypython3 -m ruff check python/sglang/srt/layers/moe/fused_moe_triton/layer.py test/registered/unit/layers/moe/test_mxfp4_expert_weight_loader.pyCI States
Latest PR Test (Base): ❌ Run #29341502637
Latest PR Test (Extra): ❌ Run #29341502576