Guard against NaNs in shader #7018
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fm3
approved these changes
Apr 26, 2023
hotzenklotz
added a commit
that referenced
this pull request
Apr 28, 2023
…ove_wkconnect * 'master' of github.com:scalableminds/webknossos: Update docker compose commands + dev install readme (#7002) Add segment groups (#6966) Add screenshot nightly test for wkorg (#7030) Workaround for WebGL crash for datasets with many segmentation layers (#6995) Fix download of public annotation, include access ctx in user cache key (#7025) Fix that changing a segment color could lead to a crash (#7000) Add more error chaining to annotation download (#7023) Guard against NaNs in shader (#7018) Store editable mappings in multiple fossildb columns+keys (#6903) Context action to move tree to group (#7005) Release 23.05.0 (#7014) Remove vault cache when reloading dataset (#7007) Fix viewing of public datasets (#7010) Update screenshots scalebar positioning (#7003) Update team members (#6999)
philippotto
added a commit
that referenced
this pull request
May 2, 2023
* guard against nan when deciding whether to use performance optimization in shader * update changelog
philippotto
added a commit
that referenced
this pull request
May 3, 2023
* Release 23.05.0 * Guard against NaNs in shader (#7018) * guard against nan when deciding whether to use performance optimization in shader * update changelog * Workaround for WebGL crash for datasets with many segmentation layers (#6995) * reduce shader complexity when having multiple segmentation layers (shader needs to be compiled more often then, though) * fix tests * clean up * update changelog * Release 23.05.1 * fix incorrect merge
philippotto
added a commit
that referenced
this pull request
May 8, 2023
* Release 23.05.0 * Guard against NaNs in shader (#7018) * guard against nan when deciding whether to use performance optimization in shader * update changelog * Workaround for WebGL crash for datasets with many segmentation layers (#6995) * reduce shader complexity when having multiple segmentation layers (shader needs to be compiled more often then, though) * fix tests * clean up * update changelog * Release 23.05.1 * Fix access check in time tracking controller (#7055) * Release 23.05.2 --------- Co-authored-by: Florian M <[email protected]>
hotzenklotz
added a commit
that referenced
this pull request
May 17, 2023
…ty-list-drawings * 'master' of github.com:scalableminds/webknossos: (25 commits) Fix issues with styling in dark mode on login page (#7052) Fix nightly by setting missing token (#7048) Release 23.05.1 (#7042) DRY types in update_actions.ts (#7036) Remove some spammy logging from backend (#7039) Use zarr string fill values (#7017) Fix voxel offset for Neuroglancer Precomputed datasets (#7019) Log when user is activated (#7027) Fix exception in applying UpdateTreeGroupVisibility skeleton action (#7037) Fix organization storage layouting (#7034) Update docker compose commands + dev install readme (#7002) Add segment groups (#6966) Add screenshot nightly test for wkorg (#7030) Workaround for WebGL crash for datasets with many segmentation layers (#6995) Fix download of public annotation, include access ctx in user cache key (#7025) Fix that changing a segment color could lead to a crash (#7000) Add more error chaining to annotation download (#7023) Guard against NaNs in shader (#7018) Store editable mappings in multiple fossildb columns+keys (#6903) Context action to move tree to group (#7005) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deciding whether to use a performance optimization in the shader, some systems produce NaN which leads to black blocks.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)