-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add segment groups #6966
Add segment groups #6966
Conversation
...tore/app/com/scalableminds/webknossos/tracingstore/tracings/volume/VolumeUpdateActions.scala
Outdated
Show resolved
Hide resolved
…nto segmentgroups-frontend
Oops, this is broken on master currently. I pushed a fix. If I merge this PR on Monday, it should be fine, I think. |
@frcroth just pointed out that the back-end review is also pending, so I extracted the fix into #7000 to not create an unnecessary pressure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend LGTM :)
- During testing I noticed that you can get -1 as group id for segments if you drag them into a group and then back into the root group. The -1 should not reach the backend/the NML. I guess this is a front end issue
…lso not that useful
…roups into skeleton context menu
…move feature for trees)
The PR should be ready now from my side :) Not sure whether we want to wait for @daniel-wer's final review or maybe it's enough if somebody else does a last round of monkey testing?
The import of skeleton groups should not be confused by segment groups anymore. I started implementing the import of segment groups, but it turned out to be a rabbit hole. In the end, the main problem was that it's not clear into which volume layer the segments should be imported (the id can change). Also, semantics-wise it is weird, because no actual volume data is imported. So, I decided together with @fm3, that the import should stick to skeletons and for everything else, the backend import should be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, well done! I didn't notice any issues during retesting 🎉
frontend/javascripts/oxalis/view/right-border-tabs/tree_hierarchy_view_helpers.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel <[email protected]>
…ove_wkconnect * 'master' of github.com:scalableminds/webknossos: Update docker compose commands + dev install readme (#7002) Add segment groups (#6966) Add screenshot nightly test for wkorg (#7030) Workaround for WebGL crash for datasets with many segmentation layers (#6995) Fix download of public annotation, include access ctx in user cache key (#7025) Fix that changing a segment color could lead to a crash (#7000) Add more error chaining to annotation download (#7023) Guard against NaNs in shader (#7018) Store editable mappings in multiple fossildb columns+keys (#6903) Context action to move tree to group (#7005) Release 23.05.0 (#7014) Remove vault cache when reloading dataset (#7007) Fix viewing of public datasets (#7010) Update screenshots scalebar positioning (#7003) Update team members (#6999)
…ty-list-drawings * 'master' of github.com:scalableminds/webknossos: (25 commits) Fix issues with styling in dark mode on login page (#7052) Fix nightly by setting missing token (#7048) Release 23.05.1 (#7042) DRY types in update_actions.ts (#7036) Remove some spammy logging from backend (#7039) Use zarr string fill values (#7017) Fix voxel offset for Neuroglancer Precomputed datasets (#7019) Log when user is activated (#7027) Fix exception in applying UpdateTreeGroupVisibility skeleton action (#7037) Fix organization storage layouting (#7034) Update docker compose commands + dev install readme (#7002) Add segment groups (#6966) Add screenshot nightly test for wkorg (#7030) Workaround for WebGL crash for datasets with many segmentation layers (#6995) Fix download of public annotation, include access ctx in user cache key (#7025) Fix that changing a segment color could lead to a crash (#7000) Add more error chaining to annotation download (#7023) Guard against NaNs in shader (#7018) Store editable mappings in multiple fossildb columns+keys (#6903) Context action to move tree to group (#7005) ...
URL of deployed dev instance (used for testing):
Steps to test:
Todo
Handle merging of groupsIssues:
(Please delete unneeded items, merge only when none are left open)