Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception in applying UpdateTreeGroupVisibility skeleton action #7037

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Apr 28, 2023

Turns out using asInstanceOf, sacrificing type safety, has its drawbacks 😬 Not sure how to improve this, since the proto-generated classes aren’t really easy to work with.

URL of deployed dev instance (used for testing):

Steps to test:

  • Create skeleton annotation, save it
  • create some tree groups
  • toggle their visibility, save, reload
  • should still load and have the right visibility

@fm3 fm3 self-assigned this Apr 28, 2023
@fm3 fm3 requested review from normanrz and philippotto April 28, 2023 15:20
@fm3 fm3 marked this pull request as ready for review April 28, 2023 15:21
@fm3 fm3 requested a review from frcroth April 28, 2023 15:22
@fm3 fm3 enabled auto-merge (squash) April 28, 2023 15:22
@fm3 fm3 merged commit def73e3 into master Apr 28, 2023
@fm3 fm3 deleted the fix-tree-group-visibility branch April 28, 2023 15:34
hotzenklotz added a commit that referenced this pull request May 3, 2023
…os into remove_wkconnect

* 'no-more-wkconnect' of github.com:scalableminds/webknossos:
  Fix exception in applying UpdateTreeGroupVisibility skeleton action (#7037)
  Fix organization storage layouting (#7034)
  adapt schema version numbers
  adapt schema number
  changelog + migration guide
  delete datastore in migration. add changelog
  snapshots, test db
  remove isConnector property for datastores
hotzenklotz added a commit that referenced this pull request May 17, 2023
…ty-list-drawings

* 'master' of github.com:scalableminds/webknossos: (25 commits)
  Fix issues with styling in dark mode on login page (#7052)
  Fix nightly by setting missing token (#7048)
  Release 23.05.1 (#7042)
  DRY types in update_actions.ts (#7036)
  Remove some spammy logging from backend (#7039)
  Use zarr string fill values (#7017)
  Fix voxel offset for Neuroglancer Precomputed datasets (#7019)
  Log when user is activated (#7027)
  Fix exception in applying UpdateTreeGroupVisibility skeleton action (#7037)
  Fix organization storage layouting (#7034)
  Update docker compose commands + dev install readme (#7002)
  Add segment groups (#6966)
  Add screenshot nightly test for wkorg (#7030)
  Workaround for WebGL crash for datasets with many segmentation layers (#6995)
  Fix download of public annotation, include access ctx in user cache key (#7025)
  Fix that changing a segment color could lead to a crash (#7000)
  Add more error chaining to annotation download (#7023)
  Guard against NaNs in shader (#7018)
  Store editable mappings in multiple fossildb columns+keys (#6903)
  Context action to move tree to group (#7005)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants