Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix viewing of public datasets #7010

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Fix viewing of public datasets #7010

merged 2 commits into from
Apr 25, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Apr 25, 2023 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • make a dataset public
  • open DS while being logged out

Issues:

(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto requested a review from fm3 April 25, 2023 08:05
@philippotto philippotto self-assigned this Apr 25, 2023
fm3
fm3 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@fm3 fm3 enabled auto-merge (squash) April 25, 2023 08:20
@fm3 fm3 merged commit 7e915c0 into master Apr 25, 2023
@fm3 fm3 deleted the fix-public-datasets branch April 25, 2023 08:24
hotzenklotz added a commit that referenced this pull request Apr 28, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into rem…
cf72393 
…ove_wkconnect

* 'master' of github.com:scalableminds/webknossos:
  Update docker compose commands + dev install readme (#7002)
  Add segment groups (#6966)
  Add screenshot nightly test for wkorg (#7030)
  Workaround for WebGL crash for datasets with many segmentation layers (#6995)
  Fix download of public annotation, include access ctx in user cache key (#7025)
  Fix that changing a segment color could lead to a crash (#7000)
  Add more error chaining to annotation download (#7023)
  Guard against NaNs in shader (#7018)
  Store editable mappings in multiple fossildb columns+keys (#6903)
  Context action to move tree to group (#7005)
  Release 23.05.0 (#7014)
  Remove vault cache when reloading dataset (#7007)
  Fix viewing of public datasets (#7010)
  Update screenshots scalebar positioning (#7003)
  Update team members (#6999)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Public datasets can no longer be viewed while logged out
2 participants
@philippotto @fm3