Guard against NaNs in shader (#7018)

* guard against nan when deciding whether to use performance optimization in shader * update changelog
scalableminds · Apr 26, 2023 · 69ce101 · 69ce101
1 parent 29ea776
commit 69ce101
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
@@ -16,6 +16,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
 ### Changed
 
 ### Fixed
+- Fixed rendering issues on some affected systems that led to "black holes". [#7018](https://github.com/scalableminds/webknossos/pull/7018)
 
 ### Removed
 

diff --git a/frontend/javascripts/oxalis/shaders/texture_access.glsl.ts b/frontend/javascripts/oxalis/shaders/texture_access.glsl.ts
@@ -202,7 +202,10 @@ export const getColorForCoords: ShaderModule = {
         offsetInBucket = mod(coords, bucketWidth);
         vec3 offsetInBucketUVW = transDim(offsetInBucket);
         if (offsetInBucketUVW.x < 0.01 || offsetInBucketUVW.y < 0.01
-            || offsetInBucketUVW.x >= 31. || offsetInBucketUVW.y >= 31.) {
+            || offsetInBucketUVW.x >= 31. || offsetInBucketUVW.y >= 31.
+            || isNan(offsetInBucketUVW.x) || isNan(offsetInBucketUVW.y)
+            || isNan(offsetInBucketUVW.z)
+          ) {
           beSafe = true;
         }
       }