Skip to content

Use lldb.eTypeOptionHideChildren for msvc tuples - #162359

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Walnut356:msvc_hide_tuple_children
Sep 6, 2026
Merged

Use lldb.eTypeOptionHideChildren for msvc tuples#162359
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Walnut356:msvc_hide_tuple_children

Conversation

@Walnut356

@Walnut356 Walnut356 commented Sep 6, 2026 •
edited by jieyouxu
Loading

Copy link
Copy Markdown
Contributor

Changes output from e.g. (8, 5.5) { 0:8, 1:5.5 } to just (8, 5.5) to match non-msvc handling.

Fixes the following tests on windows-msvc (see #161657):

  • tests\debuginfo\borrowed-tuple.rs
  • tests\debuginfo\box.rs
  • tests\debuginfo\cross-crate-spans.rs
  • tests\debuginfo\destructured-local.rs
  • tests\debuginfo\pretty-std-collections.rs
  • tests\debuginfo\simple-tuple.rs
  • tests\debuginfo\tuple-in-tuple.rs

Also partially fixes tests\debuginfo\associated-types.rs

r? @Kobzol, @jieyouxu

try-job: x86_64-msvc-1
try-job: aarch64-msvc-1

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2026
@rustbot

rustbot commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

jieyouxu
jieyouxu approved these changes Sep 6, 2026
View reviewed changes

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I tried this locally on msvc. r=me if try job comes back green.

View changes since this review

@jieyouxu

jieyouxu commented Sep 6, 2026

Copy link
Copy Markdown
Member

@bors delegate+
@bors try

@rust-bors

rust-bors Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

✌️ @Walnut356, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, then please make that change and post @bors r=jieyouxu.

View changes since this delegation.

@jieyouxu jieyouxu assigned jieyouxu and unassigned Kobzol Sep 6, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026
@bors
Auto merge of #162359 - Walnut356:msvc_hide_tuple_children, r=<try>
ac82b1e 
Use `lldb.eTypeOptionHideChildren` for msvc tuples

try-job: x86_64-msvc-1
try-job: aarch64-msvc-1
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: ac82b1e (ac82b1e0cbd635f19bae419e867c7e88b61cbdb7)
Base parent: 46a266b (46a266b9fb0fb75e05fa4c9132f7355fcb62d4a4)

@jieyouxu

jieyouxu commented Sep 6, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 41318e0 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#162359 - Walnut356:msvc_hide_tuple_children…
14aefc9 
…, r=jieyouxu

Use `lldb.eTypeOptionHideChildren` for msvc tuples

Changes output from e.g. `(8, 5.5) { 0:8, 1:5.5 }` to just `(8, 5.5)` to match non-msvc handling.

Fixes the following tests on `windows-msvc` (see rust-lang#161657):

* `tests\debuginfo\borrowed-tuple.rs`
* `tests\debuginfo\box.rs`
* `tests\debuginfo\cross-crate-spans.rs`
* `tests\debuginfo\destructured-local.rs`
* `tests\debuginfo\pretty-std-collections.rs`
* `tests\debuginfo\simple-tuple.rs`
* `tests\debuginfo\tuple-in-tuple.rs`

Also partially fixes `tests\debuginfo\associated-types.rs`

r? @Kobzol, @jieyouxu

---

try-job: x86_64-msvc-1
try-job: aarch64-msvc-1
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 6, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026
@bors
Auto merge of #162375 - JonathanBrouwer:rollup-SXRSASf, r=JonathanBro…
7392e33 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #162358 (Force u8/i8 numeric formatting on LLDB)
 - #162359 (Use `lldb.eTypeOptionHideChildren` for msvc tuples)
 - #162364 (Use `#[repr(C)]` on debuginfo test structs)
 - #162215 (remove stale/duplicate tests)
 - #162335 (Add several new LLDB feature flags)
 - #162341 (add regression test for packus_epi16 issue)
 - #162374 (Make `VaArgSafe` dyn-incompatible)
@JonathanBrouwer

JonathanBrouwer commented Sep 6, 2026

Copy link
Copy Markdown
Member

@bors try jobs=x86_64-mingw-1,x86_64-msvc-1

@rust-bors

rust-bors Bot commented Sep 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

⌛ Trying commit 41318e0 with merge ff1b68c…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/34051484083

rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026
@bors
Auto merge of #162359 - Walnut356:msvc_hide_tuple_children, r=<try>
ff1b68c 
Use `lldb.eTypeOptionHideChildren` for msvc tuples


try-job: x86_64-mingw-1
try-job: x86_64-msvc-1
@JonathanBrouwer

JonathanBrouwer commented Sep 6, 2026

Copy link
Copy Markdown
Member

@bors try cancel

@rust-bors

rust-bors Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Try build cancelled. Cancelled workflows:

Hint: if you want to run another try build, you do not need to manually cancel the previous one. Just run @bors try and bors will cancel the previous build automatically.

@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 6, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026
@bors
Auto merge of #162382 - JonathanBrouwer:rollup-YTHVgd1, r=JonathanBro…
5a2be9f 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #162358 (Force u8/i8 numeric formatting on LLDB)
 - #162359 (Use `lldb.eTypeOptionHideChildren` for msvc tuples)
 - #162364 (Use `#[repr(C)]` on debuginfo test structs)
 - #162215 (remove stale/duplicate tests)
 - #162335 (Add several new LLDB feature flags)
@rust-bors
rust-bors Bot merged commit 29a3f84 into rust-lang:main Sep 6, 2026
13 of 14 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 6, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026
@bors
Unrolled build for #162359 in rollup 162382
53d1b3d 
Rollup merge of #162359 - Walnut356:msvc_hide_tuple_children, r=jieyouxu

Use `lldb.eTypeOptionHideChildren` for msvc tuples

Changes output from e.g. `(8, 5.5) { 0:8, 1:5.5 }` to just `(8, 5.5)` to match non-msvc handling.

Fixes the following tests on `windows-msvc` (see #161657):

* `tests\debuginfo\borrowed-tuple.rs`
* `tests\debuginfo\box.rs`
* `tests\debuginfo\cross-crate-spans.rs`
* `tests\debuginfo\destructured-local.rs`
* `tests\debuginfo\pretty-std-collections.rs`
* `tests\debuginfo\simple-tuple.rs`
* `tests\debuginfo\tuple-in-tuple.rs`

Also partially fixes `tests\debuginfo\associated-types.rs`

r? @Kobzol, @jieyouxu

---

try-job: x86_64-msvc-1
try-job: aarch64-msvc-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Walnut356 @rustbot @jieyouxu @JonathanBrouwer @Kobzol