Force u8/i8 numeric formatting on LLDB by Walnut356 · Pull Request #162358 · rust-lang/rust

Walnut356 · 2026-09-06T08:16:04Z

Resolves a very common annoyance with the existing visualizers. This doesn't touch the behavior that formats char pointers as c-strings since that's its own can of worms (and likely needs to be handled alongside adding the wide pointer visualizer).

I disabled checking Rc<str> in strings-and-strs.rs, as this patch caused it to fail on windows-gnu and the fix is the wide pointer visualizer. Technically, even on linux-gnu the test only works because it's seemingly somewhat reliable for there to be a null byte directly after the str data, but that's obviously not something we should be relying on.

Also fixes tests\debuginfo\borrowed-unique-basic.rs on windows-msvc as part of #161657 (comment)

r? @Kobzol, @jieyouxu

try-job: aarch64-apple-1
try-job: x86_64-mingw-1

rustbot · 2026-09-06T08:16:09Z

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

jieyouxu

Thanks, this looks much more sensible.
r? me

View changes since this review

jieyouxu · 2026-09-06T10:21:00Z

You can r=me if try jobs come back green.
@bors rollup=iffy note="debuginfo tests"
@bors delegate+
@bors try

rust-bors · 2026-09-06T10:21:03Z

✌️ @Walnut356, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, then please make that change and post @bors r=jieyouxu.

View changes since this delegation.

Force u8/i8 numeric formatting on LLDB try-job: aarch64-apple-1 try-job: x86_64-mingw-1

rust-bors · 2026-09-06T13:25:26Z

☀️ Try build successful (CI)
Build commit: 143c4cb (143c4cbc82e846c5edd37c1050d022551fcefe06)
Base parent: 46a266b (46a266b9fb0fb75e05fa4c9132f7355fcb62d4a4)

jieyouxu · 2026-09-06T13:37:19Z

@bors r+

rust-bors · 2026-09-06T13:37:21Z

📌 Commit cc3786d has been approved by jieyouxu

It is now in the queue for this repository.

@Kobzol

Force u8/i8 numeric formatting on LLDB Resolves a very common annoyance with the existing visualizers. This doesn't touch the behavior that formats char pointers as c-strings since that's its own can of worms (and likely needs to be handled alongside adding the wide pointer visualizer). I disabled checking `Rc<str>` in `strings-and-strs.rs`, as this patch caused it to fail on `windows-gnu` and the fix is the wide pointer visualizer. Technically, even on `linux-gnu` the test only works because it's seemingly somewhat reliable for there to be a null byte directly after the `str` data, but that's obviously not something we should be relying on. Also fixes `tests\debuginfo\borrowed-unique-basic.rs` on `windows-msvc` as part of rust-lang#161657 (comment) r? @Kobzol, @jieyouxu --- try-job: aarch64-apple-1 try-job: x86_64-mingw-1

…uwer Rollup of 7 pull requests Successful merges: - #162358 (Force u8/i8 numeric formatting on LLDB) - #162359 (Use `lldb.eTypeOptionHideChildren` for msvc tuples) - #162364 (Use `#[repr(C)]` on debuginfo test structs) - #162215 (remove stale/duplicate tests) - #162335 (Add several new LLDB feature flags) - #162341 (add regression test for packus_epi16 issue) - #162374 (Make `VaArgSafe` dyn-incompatible)

rust-bors · 2026-09-06T17:04:23Z

⌛ Testing commit cc3786d with merge 0914295...

Workflow: https://github.com/rust-lang/rust/actions/runs/34047443657

@Kobzol

Force u8/i8 numeric formatting on LLDB Resolves a very common annoyance with the existing visualizers. This doesn't touch the behavior that formats char pointers as c-strings since that's its own can of worms (and likely needs to be handled alongside adding the wide pointer visualizer). I disabled checking `Rc<str>` in `strings-and-strs.rs`, as this patch caused it to fail on `windows-gnu` and the fix is the wide pointer visualizer. Technically, even on `linux-gnu` the test only works because it's seemingly somewhat reliable for there to be a null byte directly after the `str` data, but that's obviously not something we should be relying on. Also fixes `tests\debuginfo\borrowed-unique-basic.rs` on `windows-msvc` as part of #161657 (comment) r? @Kobzol, @jieyouxu --- try-job: aarch64-apple-1 try-job: x86_64-mingw-1

JonathanBrouwer · 2026-09-06T18:21:52Z

@bors try jobs=x86_64-mingw-1,x86_64-msvc-1

rust-bors · 2026-09-06T18:21:58Z

⌛ Trying commit cc3786d with merge 3519084…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/34051480535

Force u8/i8 numeric formatting on LLDB try-job: x86_64-mingw-1 try-job: x86_64-msvc-1

JonathanBrouwer · 2026-09-06T18:22:35Z

@bors try cancel

rust-bors · 2026-09-06T18:22:38Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/34051480535

Hint: if you want to run another try build, you do not need to manually cancel the previous one. Just run @bors try and bors will cancel the previous build automatically.

JonathanBrouwer · 2026-09-06T18:24:41Z

@bors yield
One of the jobs from the autojobs is still queued, github?
Yielding to enclosing rollup

rust-bors · 2026-09-06T18:24:44Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/34047443657

The next pull request likely to be tested is #162382.

…uwer Rollup of 5 pull requests Successful merges: - #162358 (Force u8/i8 numeric formatting on LLDB) - #162359 (Use `lldb.eTypeOptionHideChildren` for msvc tuples) - #162364 (Use `#[repr(C)]` on debuginfo test structs) - #162215 (remove stale/duplicate tests) - #162335 (Add several new LLDB feature flags)

@Kobzol

Rollup merge of #162358 - Walnut356:u8_i8_fmt, r=jieyouxu Force u8/i8 numeric formatting on LLDB Resolves a very common annoyance with the existing visualizers. This doesn't touch the behavior that formats char pointers as c-strings since that's its own can of worms (and likely needs to be handled alongside adding the wide pointer visualizer). I disabled checking `Rc<str>` in `strings-and-strs.rs`, as this patch caused it to fail on `windows-gnu` and the fix is the wide pointer visualizer. Technically, even on `linux-gnu` the test only works because it's seemingly somewhat reliable for there to be a null byte directly after the `str` data, but that's obviously not something we should be relying on. Also fixes `tests\debuginfo\borrowed-unique-basic.rs` on `windows-msvc` as part of #161657 (comment) r? @Kobzol, @jieyouxu --- try-job: aarch64-apple-1 try-job: x86_64-mingw-1

force u8/i8 numeric formatting for lldb

cc3786d

rustbot assigned Kobzol Sep 6, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 6, 2026

jieyouxu approved these changes Sep 6, 2026

View reviewed changes

rustbot assigned jieyouxu and unassigned Kobzol Sep 6, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026

Auto merge of #162358 - Walnut356:u8_i8_fmt, r=<try>

143c4cb

Force u8/i8 numeric formatting on LLDB try-job: aarch64-apple-1 try-job: x86_64-mingw-1

This comment was marked as off-topic.

Sign in to view

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2026

JonathanBrouwer mentioned this pull request Sep 6, 2026

Rollup of 7 pull requests #162375

Closed

rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026

Auto merge of #162358 - Walnut356:u8_i8_fmt, r=<try>

3519084

Force u8/i8 numeric formatting on LLDB try-job: x86_64-mingw-1 try-job: x86_64-msvc-1

JonathanBrouwer mentioned this pull request Sep 6, 2026

Rollup of 5 pull requests #162382

Merged

rust-bors Bot merged commit 45adcad into rust-lang:main Sep 6, 2026
13 of 15 checks passed

rustbot added this to the 1.100.0 milestone Sep 6, 2026

Uh oh!

Uh oh!

Conversation

Walnut356 commented Sep 6, 2026 • edited by jieyouxu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 6, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Sep 6, 2026

Uh oh!

rust-bors Bot commented Sep 6, 2026

Uh oh!

This comment has been minimized.

This comment was marked as off-topic.

This comment was marked as off-topic.

rust-bors Bot commented Sep 6, 2026

Uh oh!

jieyouxu commented Sep 6, 2026

Uh oh!

rust-bors Bot commented Sep 6, 2026

Uh oh!

rust-bors Bot commented Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Sep 6, 2026

Uh oh!

rust-bors Bot commented Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Sep 6, 2026

Uh oh!

rust-bors Bot commented Sep 6, 2026

Uh oh!

JonathanBrouwer commented Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented Sep 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Walnut356 commented Sep 6, 2026 •

edited by jieyouxu

Loading

jieyouxu left a comment •

edited by rustbot

Loading

rust-bors Bot commented Sep 6, 2026 •

edited

Loading

rust-bors Bot commented Sep 6, 2026 •

edited

Loading

JonathanBrouwer commented Sep 6, 2026 •

edited

Loading