Update Fira Mono License Information by kaepr · Pull Request #154812 · rust-lang/rust

kaepr · 2026-04-04T14:22:08Z

Update license information for Fira Mono font.

The license itself seems to be identical as FiraSans license, but didn't reuse it's file as it was explicitly named FiraSans-LICENSE.

Added a new LICENSE from https://github.com/mozilla/Fira/blob/master/LICENSE and updated build and static files setup.

./x doc library worked fine locally and was able to see the mono license being minified and served as well.

rustbot · 2026-04-04T14:22:12Z

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @lolbinarycat

rustbot · 2026-04-04T14:22:14Z

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: rustdoc
rustdoc expanded to 9 candidates
Random selection from GuillaumeGomez, camelid, fmease, lolbinarycat, notriddle

notriddle · 2026-04-06T00:48:01Z

Does anyone know why this line is present in FiraSans-LICENSE.txt, but not in FiraMono-LICENSE.txt?

--- src/librustdoc/html/static/fonts/FiraSans-LICENSE.txt	2024-02-24 15:12:23
+++ src/librustdoc/html/static/fonts/FiraMono-LICENSE.txt	2026-04-05 17:46:00
@@ -1,7 +1,6 @@
 // REUSE-IgnoreStart
 
 Digitized data copyright (c) 2012-2015, The Mozilla Foundation and Telefonica S.A.
-with Reserved Font Name < Fira >,
 
 This Font Software is licensed under the SIL Open Font License, Version 1.1.
 This license is copied below, and is also available with a FAQ at:

kaepr · 2026-04-06T02:57:34Z

I saw some similar discussions related to "-with Reserved Font Name < Fira >,"

It seems to have been reverted in this PR https://github.com/mozilla/Fira/pull/219/changes

This issue was originated in mozilla/Fira#218

So it seems like FiraSans-LICENSE used this earlier version of the license, with the reserved font name, and now licenses don't include explicit name reservation.

I think we have the below 2 options

Add a new Fira-LICENSE.txt, update copyright.txt and refer all Fira fonts to this file. Remove FiraSans-LICENSE
Add a new FiraMono license and update copyright to refer Fira Mono to this license. (This PR)

notriddle · 2026-04-06T03:49:09Z

Add a new Fira-LICENSE.txt, update copyright.txt and refer all Fira fonts to this file. Remove FiraSans-LICENSE

Personally, I would prefer this option. FiraSans-Regular, -Bold, and -Italic all share a single license file, so why can't FiraMono?

kaepr · 2026-04-06T04:06:50Z

I agree, first option makes most sense. Will update the commit soon.

kaepr · 2026-04-06T12:57:42Z

I agree, first option makes most sense. Will update the commit soon.

Done, re-used the existing license, just renamed it.

notriddle · 2026-04-07T02:55:43Z

@bors r=notriddle,lolbinarycat

rust-bors · 2026-04-07T02:55:46Z

📌 Commit adaff73 has been approved by notriddle,lolbinarycat

It is now in the queue for this repository.

…le,lolbinarycat Update Fira Mono License Information Update license information for Fira Mono font. The license itself seems to be identical as `FiraSans` license, but didn't reuse it's file as it was explicitly named `FiraSans-LICENSE`. Added a new LICENSE from https://github.com/mozilla/Fira/blob/master/LICENSE and updated `build` and `static` files setup. `./x doc library` worked fine locally and was able to see the mono license being minified and served as well.

Rollup of 6 pull requests Successful merges: - #154812 (Update Fira Mono License Information) - #154886 (Stabilize check-cfg suggestions for symbol) - #154889 (Update wasm-component-ld to 0.5.22) - #154761 (coretests: add argument order regression tests for min_by/max_by/minmax_by) - #154825 (constify `Step for NonZero<u*>`) - #154837 (library: std: motor: use OS' process::exit in abort_internal)

JonathanBrouwer · 2026-04-07T14:31:00Z

@bors try jobs=i686-msvc-2
Debugging stuck rollup #154926

Update Fira Mono License Information try-job: i686-msvc-2

…le,lolbinarycat Update Fira Mono License Information Update license information for Fira Mono font. The license itself seems to be identical as `FiraSans` license, but didn't reuse it's file as it was explicitly named `FiraSans-LICENSE`. Added a new LICENSE from https://github.com/mozilla/Fira/blob/master/LICENSE and updated `build` and `static` files setup. `./x doc library` worked fine locally and was able to see the mono license being minified and served as well.

rust-bors · 2026-04-07T16:48:23Z

☀️ Try build successful (CI)
Build commit: c92385b (c92385bdb61475be68daf2e969556e0f466a7a52, parent: 49b6ac01d6f4c3da812039ae846407a20961aa4c)

…uwer Rollup of 22 pull requests Successful merges: - #150965 (Fix no results when searching for == in doc) - #153999 (Remove `TaggedQueryKey::def_kind`) - #154146 (Split out the creation of `Cycle` to a new `process_cycle` function) - #154147 (Do not attempt generating DllImport for extern types) - #154812 (Update Fira Mono License Information) - #154880 (bootstrap: minor improvements to download-rustc) - #154886 (Stabilize check-cfg suggestions for symbol) - #154889 (Update wasm-component-ld to 0.5.22) - #154928 (Fix pin docs) - #154942 (delegation: generate more verbose error delegation) - #153269 (GCI: During reachability analysis don't try to evaluate the initializer of overly generic free const items) - #154506 (Migrate some tests from `tests/ui/issues` to appropriate directories) - #154673 (Use a different name for fast try builds) - #154761 (coretests: add argument order regression tests for min_by/max_by/minmax_by) - #154795 (Add more info about where autodiff can be applied) - #154808 (Post-attribute ports cleanup pt. 1) - #154825 (constify `Step for NonZero<u*>`) - #154837 (library: std: motor: use OS' process::exit in abort_internal) - #154866 (add regression test for #146514) - #154922 (c-b: Export inverse hyperbolic trigonometric functions) - #154931 (delegation(small cleanup): remove not needed PhantomData) - #154950 (library: no `cfg(target_arch)` on scalable intrinsics)

Rollup merge of #154812 - kaepr:fira-mono-license, r=notriddle,lolbinarycat Update Fira Mono License Information Update license information for Fira Mono font. The license itself seems to be identical as `FiraSans` license, but didn't reuse it's file as it was explicitly named `FiraSans-LICENSE`. Added a new LICENSE from https://github.com/mozilla/Fira/blob/master/LICENSE and updated `build` and `static` files setup. `./x doc library` worked fine locally and was able to see the mono license being minified and served as well.

…uwer Rollup of 22 pull requests Successful merges: - rust-lang/rust#150965 (Fix no results when searching for == in doc) - rust-lang/rust#153999 (Remove `TaggedQueryKey::def_kind`) - rust-lang/rust#154146 (Split out the creation of `Cycle` to a new `process_cycle` function) - rust-lang/rust#154147 (Do not attempt generating DllImport for extern types) - rust-lang/rust#154812 (Update Fira Mono License Information) - rust-lang/rust#154880 (bootstrap: minor improvements to download-rustc) - rust-lang/rust#154886 (Stabilize check-cfg suggestions for symbol) - rust-lang/rust#154889 (Update wasm-component-ld to 0.5.22) - rust-lang/rust#154928 (Fix pin docs) - rust-lang/rust#154942 (delegation: generate more verbose error delegation) - rust-lang/rust#153269 (GCI: During reachability analysis don't try to evaluate the initializer of overly generic free const items) - rust-lang/rust#154506 (Migrate some tests from `tests/ui/issues` to appropriate directories) - rust-lang/rust#154673 (Use a different name for fast try builds) - rust-lang/rust#154761 (coretests: add argument order regression tests for min_by/max_by/minmax_by) - rust-lang/rust#154795 (Add more info about where autodiff can be applied) - rust-lang/rust#154808 (Post-attribute ports cleanup pt. 1) - rust-lang/rust#154825 (constify `Step for NonZero<u*>`) - rust-lang/rust#154837 (library: std: motor: use OS' process::exit in abort_internal) - rust-lang/rust#154866 (add regression test for rust-lang/rust#146514) - rust-lang/rust#154922 (c-b: Export inverse hyperbolic trigonometric functions) - rust-lang/rust#154931 (delegation(small cleanup): remove not needed PhantomData) - rust-lang/rust#154950 (library: no `cfg(target_arch)` on scalable intrinsics)

Update Fira Mono License Information

e7a00df

rustbot assigned notriddle Apr 4, 2026

This comment has been minimized.

Sign in to view

Update license-metadata with FiraMono license

29d70d4

kaepr added 3 commits April 6, 2026 16:52

Re-use existing Fira(Sans) license for Mono fonts

9d96a26

Update static_files to only include fira_license

057b24e

fixes rustdoc build script

adaff73

notriddle approved these changes Apr 7, 2026

View reviewed changes

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2026

jhpratt mentioned this pull request Apr 7, 2026

Rollup of 6 pull requests #154926

Closed

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Apr 7, 2026

Auto merge of #154812 - kaepr:fira-mono-license, r=<try>

c92385b

Update Fira Mono License Information try-job: i686-msvc-2

JonathanBrouwer mentioned this pull request Apr 7, 2026

Rollup of 22 pull requests #154958

Merged

rust-bors bot merged commit 91b6321 into rust-lang:main Apr 7, 2026
12 checks passed

kaepr deleted the fira-mono-license branch April 8, 2026 02:35

Uh oh!

Conversation

kaepr commented Apr 4, 2026

Uh oh!

rustbot commented Apr 4, 2026

Uh oh!

rustbot commented Apr 4, 2026

Uh oh!

This comment has been minimized.

notriddle commented Apr 6, 2026

Uh oh!

kaepr commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

notriddle commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kaepr commented Apr 6, 2026

Uh oh!

kaepr commented Apr 6, 2026

Uh oh!

notriddle commented Apr 7, 2026

Uh oh!

rust-bors bot commented Apr 7, 2026

Uh oh!

JonathanBrouwer commented Apr 7, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kaepr commented Apr 6, 2026 •

edited

Loading

notriddle commented Apr 6, 2026 •

edited

Loading