Migrate some tests from tests/ui/issues to appropriate directories

[ujjwalvishwakarma2006]

The following changes have been made in the pull request:

• tests/ui/issues/issue-25746-bool-transmute.rs ➝ tests/ui/transmute/transmute-bool-u8.rs
• tests/ui/issues/issue-32377.{rs,stderr} ➝ tests/ui/intrinsics/transmute-phantomdata-generic-unequal-size.{rs,stderr}

The issue links have also been added at the top of each .rs file.

r? Kivooeo

[Kivooeo]

could you please investigate original issue, it seems like this is not transmute problem

[ujjwalvishwakarma2006]

Could you please give a hint as to which directory it should belong to? (Or maybe just the part of the test file that indicates that the test might not be related to transmute).

[Kivooeo]

I'd like if you do your own investigation and found root cause of problem in that code, and decide whether it's fine to stay here, should be moved somewhere else or be deleted, one of requirement for the project is independence

[ujjwalvishwakarma2006]

From my perspective, the following could be potentially appropriate directories (not in priority order):

• tests/ui/instrinsics: reason; because earlier instrinsicck was used to replace types with isize to compare sizes of two dynamically sized types.
• tests/ui/associated-types: reason; the description mentions that

Tests focused on associated types. If the associated type is not in a trait definition, it belongs in the tests/ui/associated-inherent-types/ directory. Aspects exercised include, e.g., default associated types, overriding defaults, and type inference.

• tests/ui/impl-traits: reason; some similar tests exist, but no transmutes are used.
• tests/ui/layout: reason; as the memory layout of the [u8; 2] and struct Bar is different.
• tests/ui/dst: reason; maybe because [u8; N] is dynamically sized

I am trying to figure out other potential candidates.

But as of now, transmute suits the most in my opinion, as most of the tests giving cannot transmute between different-sized types error are in the transmute directory only.

I take the just-above sentence back. Now, tests/ui/intrinsics is the most appropriate one here, imo.

[Kivooeo]

But as of now, transmute suits the most in my opinion, as most of the tests giving cannot transmute between different-sized types error are in the transmute directory only.

it's not about error message, it's about why this code originally was failing

[Kivooeo]

it means, if you see word transmute in test, it's not always have to go to transmute directory

[ujjwalvishwakarma2006]

Here is my understanding of the test:

• This test checks if we can transmute from one data type to another data type when they have different types and memory layouts.
• It results in ICE, because earlier the compiler used to replace generic types with isize to deduce the size of the types whose size can't be deduced at compile time.

---

Oh, wait, it may belong to tests/ui/intrinsics. See here. This particular comment mentions the second point that I wrote above. And it's the duty of intrinsic, so it may also be a potential candidate. I have updated this in the upper comment as well.
This is the most appropriate now. (even better than transmute, imo)

[Kivooeo]

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[Kivooeo]

@bors r+ rollup

[rust-bors]

📌 Commit 9181351 has been approved by Kivooeo

It is now in the queue for this repository.