bootstrap: minor improvements to download-rustc by jyn514 · Pull Request #154880 · rust-lang/rust

jyn514 · 2026-04-06T11:59:59Z

Split out from #154243.

rustbot · 2026-04-06T12:00:03Z

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

rustbot · 2026-04-06T12:00:06Z

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: bootstrap
bootstrap expanded to 6 candidates
Random selection from Mark-Simulacrum, clubby789

Kobzol · 2026-04-06T18:31:25Z

That sounds very useful, nice! I'll let jieyouxu also let a look since he assigned himself, but otherwise r=me.

jieyouxu

Thanks, some non-blocking nits. You can r= Jakub and me with or without these nits.

@bors delegate+

View changes since this review

src/bootstrap/src/core/config/config.rs

rust-bors · 2026-04-07T08:12:19Z

✌️ @jyn514, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, then please make that change and post @bors r=jieyouxu.

jieyouxu · 2026-04-07T08:12:41Z

@rustbot author

Example output: ``` $ x b compiler Building bootstrap Finished `dev` profile [unoptimized] target(s) in 0.02s NOTE: detected 3 modifications that could affect a build of rustc - src/bootstrap/src/core/config/config.rs - src/bootstrap/src/core/download.rs - src/build_helper/src/git.rs skipping rustc download due to `download-rustc = 'if-unchanged'` Building stage1 compiler artifacts (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.72s Creating a sysroot for stage1 compiler (use `rustup toolchain link 'name' build/host/stage1`) Build completed successfully in 0:00:05 ```

Anything that can change there can also be changed in bootstrap.toml. We have a separate check to make sure that the local config is compatable with CI's config.

jyn514 · 2026-04-07T14:11:40Z

@bors r=Kobzol,jieyouxu

rust-bors · 2026-04-07T14:11:45Z

📌 Commit 9b5e085 has been approved by Kobzol,jieyouxu

It is now in the queue for this repository.

…vements, r=Kobzol,jieyouxu bootstrap: minor improvements to download-rustc Split out from rust-lang#154243.

…uwer Rollup of 22 pull requests Successful merges: - #150965 (Fix no results when searching for == in doc) - #153999 (Remove `TaggedQueryKey::def_kind`) - #154146 (Split out the creation of `Cycle` to a new `process_cycle` function) - #154147 (Do not attempt generating DllImport for extern types) - #154812 (Update Fira Mono License Information) - #154880 (bootstrap: minor improvements to download-rustc) - #154886 (Stabilize check-cfg suggestions for symbol) - #154889 (Update wasm-component-ld to 0.5.22) - #154928 (Fix pin docs) - #154942 (delegation: generate more verbose error delegation) - #153269 (GCI: During reachability analysis don't try to evaluate the initializer of overly generic free const items) - #154506 (Migrate some tests from `tests/ui/issues` to appropriate directories) - #154673 (Use a different name for fast try builds) - #154761 (coretests: add argument order regression tests for min_by/max_by/minmax_by) - #154795 (Add more info about where autodiff can be applied) - #154808 (Post-attribute ports cleanup pt. 1) - #154825 (constify `Step for NonZero<u*>`) - #154837 (library: std: motor: use OS' process::exit in abort_internal) - #154866 (add regression test for #146514) - #154922 (c-b: Export inverse hyperbolic trigonometric functions) - #154931 (delegation(small cleanup): remove not needed PhantomData) - #154950 (library: no `cfg(target_arch)` on scalable intrinsics)

Rollup merge of #154880 - ferrocene:jyn/download-rustc-improvements, r=Kobzol,jieyouxu bootstrap: minor improvements to download-rustc Split out from #154243.

…uwer Rollup of 22 pull requests Successful merges: - rust-lang/rust#150965 (Fix no results when searching for == in doc) - rust-lang/rust#153999 (Remove `TaggedQueryKey::def_kind`) - rust-lang/rust#154146 (Split out the creation of `Cycle` to a new `process_cycle` function) - rust-lang/rust#154147 (Do not attempt generating DllImport for extern types) - rust-lang/rust#154812 (Update Fira Mono License Information) - rust-lang/rust#154880 (bootstrap: minor improvements to download-rustc) - rust-lang/rust#154886 (Stabilize check-cfg suggestions for symbol) - rust-lang/rust#154889 (Update wasm-component-ld to 0.5.22) - rust-lang/rust#154928 (Fix pin docs) - rust-lang/rust#154942 (delegation: generate more verbose error delegation) - rust-lang/rust#153269 (GCI: During reachability analysis don't try to evaluate the initializer of overly generic free const items) - rust-lang/rust#154506 (Migrate some tests from `tests/ui/issues` to appropriate directories) - rust-lang/rust#154673 (Use a different name for fast try builds) - rust-lang/rust#154761 (coretests: add argument order regression tests for min_by/max_by/minmax_by) - rust-lang/rust#154795 (Add more info about where autodiff can be applied) - rust-lang/rust#154808 (Post-attribute ports cleanup pt. 1) - rust-lang/rust#154825 (constify `Step for NonZero<u*>`) - rust-lang/rust#154837 (library: std: motor: use OS' process::exit in abort_internal) - rust-lang/rust#154866 (add regression test for rust-lang/rust#146514) - rust-lang/rust#154922 (c-b: Export inverse hyperbolic trigonometric functions) - rust-lang/rust#154931 (delegation(small cleanup): remove not needed PhantomData) - rust-lang/rust#154950 (library: no `cfg(target_arch)` on scalable intrinsics)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 6, 2026

rustbot assigned clubby789 Apr 6, 2026

jieyouxu self-assigned this Apr 6, 2026

jieyouxu approved these changes Apr 7, 2026

View reviewed changes

src/bootstrap/src/core/config/config.rs Show resolved Hide resolved

src/bootstrap/src/core/config/config.rs Outdated Show resolved Hide resolved

jieyouxu assigned Kobzol and unassigned clubby789 Apr 7, 2026

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2026

jyn514 added 2 commits April 7, 2026 16:10

Don't consider bootstrap/defaults to invalidate the rustc cache

9b5e085

Anything that can change there can also be changed in bootstrap.toml. We have a separate check to make sure that the local config is compatable with CI's config.

jyn514 force-pushed the jyn/download-rustc-improvements branch from 406fc2f to 9b5e085 Compare April 7, 2026 14:10

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 7, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 7, 2026

Rollup merge of rust-lang#154880 - ferrocene:jyn/download-rustc-impro…

b5f2453

…vements, r=Kobzol,jieyouxu bootstrap: minor improvements to download-rustc Split out from rust-lang#154243.

JonathanBrouwer mentioned this pull request Apr 7, 2026

Rollup of 22 pull requests #154958

Merged

rust-bors bot merged commit e0ce351 into rust-lang:main Apr 7, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Apr 7, 2026

rust-timer added a commit that referenced this pull request Apr 7, 2026

Unrolled build for #154880

1815f06

Rollup merge of #154880 - ferrocene:jyn/download-rustc-improvements, r=Kobzol,jieyouxu bootstrap: minor improvements to download-rustc Split out from #154243.

jyn514 deleted the jyn/download-rustc-improvements branch April 8, 2026 02:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

bootstrap: minor improvements to download-rustc#154880

bootstrap: minor improvements to download-rustc#154880
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
ferrocene:jyn/download-rustc-improvements

jyn514 commented Apr 6, 2026

Uh oh!

rustbot commented Apr 6, 2026

Uh oh!

rustbot commented Apr 6, 2026

Uh oh!

Kobzol commented Apr 6, 2026

Uh oh!

jieyouxu left a comment •

edited by rustbot

Loading

Uh oh!

Uh oh!

Uh oh!

rust-bors bot commented Apr 7, 2026

Uh oh!

jieyouxu commented Apr 7, 2026

Uh oh!

jyn514 commented Apr 7, 2026

Uh oh!

rust-bors bot commented Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

jyn514 commented Apr 6, 2026

Uh oh!

rustbot commented Apr 6, 2026

Uh oh!

rustbot commented Apr 6, 2026

Uh oh!

Kobzol commented Apr 6, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rust-bors bot commented Apr 7, 2026

Uh oh!

jieyouxu commented Apr 7, 2026

Uh oh!

jyn514 commented Apr 7, 2026

Uh oh!

rust-bors bot commented Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jieyouxu left a comment •

edited by rustbot

Loading