Closed
Conversation
…ax_by A recent regression swapped the argument order passed to the compare closure in min_by, max_by and minmax_by (compare(&v2, &v1) instead of compare(&v1, &v2)). This was fixed, but no regression test was added. Add tests that record the arguments the compare closure receives and assert they match (v1, v2) — the documented contract.
abort_internal() is used in panics; if it calls core::intrinsics::abort(), the process triggers an invalid op code (on x86_64), which is a much harder "abort" than a user-controlled exit via a panic. Most other OSes don't use core::intrinsics::abort() here, but either libc::abort(), or a native OS abort/exit API.
Same as 147495, just keeping it up-to-date.
…le,lolbinarycat Update Fira Mono License Information Update license information for Fira Mono font. The license itself seems to be identical as `FiraSans` license, but didn't reuse it's file as it was explicitly named `FiraSans-LICENSE`. Added a new LICENSE from https://github.com/mozilla/Fira/blob/master/LICENSE and updated `build` and `static` files setup. `./x doc library` worked fine locally and was able to see the mono license being minified and served as well.
…JonathanBrouwer Stabilize check-cfg suggestions for symbol When I was working on rust-lang#154794, I found a weird CI fail rust-lang#154794 (comment), I finally found this caused by unstable cfg suggestions by using `FxHashSet`(from PR rust-lang#154777). Because my PR by luck insert a new symbol, which makes the final diagnostic order changed. It's a standalone issue, so it's better to fix in a separate PR.
…-ld, r=Mark-Simulacrum Update wasm-component-ld to 0.5.22 Same as rust-lang#147495, just keeping it up-to-date.
…cmp-argument-order, r=jhpratt coretests: add argument order regression tests for min_by/max_by/minmax_by PR rust-lang#136307 introduced a regression in min_by, max_by, and minmax_by: the compare closure received arguments as (v2, v1) instead of (v1, v2), contrary to the documented contract. Although this was fixed in rust-lang#139357, no regression tests were added. This PR adds regression tests for all three functions, verifying that compare always receives arguments in the documented order (v1, v2). As a bonus: first coretests coverage for minmax_by.
… r=jhpratt constify `Step for NonZero<u*>` Tracking Issue: rust-lang#42168 I missed the constification of `Step for NonZero<u*>` in the recent rust-lang#153821, so here they are. Had to constify the `Clone` / `TrivialClone` impls along the way rust-lang#142757 .
library: std: motor: use OS' process::exit in abort_internal abort_internal() is used in panics; if it calls core::intrinsics::abort(), the process triggers an invalid op code (on x86_64), which is a much harder "abort" than a user-controlled exit via a panic. Most other OSes don't use core::intrinsics::abort() here, but either libc::abort(), or a native OS abort/exit API.
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit ad5d912 with merge a0d655f... Workflow: https://github.com/rust-lang/rust/actions/runs/24071161432 |
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 7, 2026
Rollup of 6 pull requests Successful merges: - #154812 (Update Fira Mono License Information) - #154886 (Stabilize check-cfg suggestions for symbol) - #154889 (Update wasm-component-ld to 0.5.22) - #154761 (coretests: add argument order regression tests for min_by/max_by/minmax_by) - #154825 (constify `Step for NonZero<u*>`) - #154837 (library: std: motor: use OS' process::exit in abort_internal)
Contributor
rust-bors
bot
added
the
S-waiting-on-author
rust-bors
bot
removed
the
S-waiting-on-bors
Contributor
|
This pull request was unapproved. Auto build was cancelled due to unapproval. Cancelled workflows: |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 7, 2026
Rollup of 6 pull requests try-job: i686-msvc-2
This was referenced Apr 7, 2026
Contributor
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Step for NonZero<u*>#154825 (constifyStep for NonZero<u*>)r? @ghost
Create a similar rollup