This repository was archived by the owner on Apr 14, 2021. It is now read-only.
[2.0] Add a feature flag for bundle install not —cacheing by default#5724
Closed
[2.0] Add a feature flag for bundle install not —cacheing by default#5724
bundle install not —cacheing by default#5724Conversation
segiddins
changed the title
bundle install not —cacheing by defaultbundle install not —cacheing by default
Collaborator
|
☔ The latest upstream changes (presumably #5722) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r+ |
segiddins
force-pushed
the
seg-install-does-not-cache-by-default
branch
from
35fe424 to
8a5172d
Compare
Collaborator
|
☔ The latest upstream changes (presumably #5727) made this pull request unmergeable. Please resolve the merge conflicts. |
segiddins
force-pushed
the
seg-install-does-not-cache-by-default
branch
from
8a5172d to
20d945f
Compare
bundlerbot
added a commit
that referenced
this pull request
Jun 20, 2017
…lby-swandale
[CLI] Dont print defaults in the command printed with --verbose
### What was the end-user problem that led to this PR?
The problem was that running `bundle lock --verbose` would print
Running `bundle lock --add-platform --remove-platform --verbose` with bundler 1.15.1
even though the platform flags were never specified. This was surfaced by #5724, which will be fixed by this PR.
### Was was your diagnosis of the problem?
My diagnosis was that default values of options were being printed.
### What is your fix for the problem, implemented in this PR?
My fix is to filter out the default values before getting Thor
### Why did you choose this fix out of the possible options?
I chose this fix because there is no way, within the `CLI` instance, to tell which flags the user has explicitly given, so I felt that filtering out those options that had default values was the next-best thing.
bundlerbot
added a commit
that referenced
this pull request
Jun 20, 2017
…lby-swandale
[CLI] Dont print defaults in the command printed with --verbose
### What was the end-user problem that led to this PR?
The problem was that running `bundle lock --verbose` would print
Running `bundle lock --add-platform --remove-platform --verbose` with bundler 1.15.1
even though the platform flags were never specified. This was surfaced by #5724, which will be fixed by this PR.
### Was was your diagnosis of the problem?
My diagnosis was that default values of options were being printed.
### What is your fix for the problem, implemented in this PR?
My fix is to filter out the default values before getting Thor
### Why did you choose this fix out of the possible options?
I chose this fix because there is no way, within the `CLI` instance, to tell which flags the user has explicitly given, so I felt that filtering out those options that had default values was the next-best thing.
Collaborator
|
☔ The latest upstream changes (presumably #5788) made this pull request unmergeable. Please resolve the merge conflicts. |
segiddins
force-pushed
the
seg-install-does-not-cache-by-default
branch
from
20d945f to
20aa759
Compare
Contributor
Author
|
Rebased. Only 1.0 failure was due to trampolining, which is now gone. |
Contributor
Author
|
This causes a few changes of behavior that we need to decide if we want to fix or change: |
Collaborator
|
☔ The latest upstream changes (presumably #5790) made this pull request unmergeable. Please resolve the merge conflicts. |
segiddins
force-pushed
the
seg-install-does-not-cache-by-default
branch
from
20aa759 to
aee6bcd
Compare
Contributor
Author
|
Rebased. |
segiddins
force-pushed
the
seg-install-does-not-cache-by-default
branch
from
aee6bcd to
1bb460b
Compare
segiddins
force-pushed
the
seg-install-does-not-cache-by-default
branch
from
1bb460b to
ae0363d
Compare
Collaborator
|
☔ The latest upstream changes (presumably #5839) made this pull request unmergeable. Please resolve the merge conflicts. |
segiddins
pushed a commit
that referenced
this pull request
Jul 17, 2017
…lby-swandale
[CLI] Dont print defaults in the command printed with --verbose
### What was the end-user problem that led to this PR?
The problem was that running `bundle lock --verbose` would print
Running `bundle lock --add-platform --remove-platform --verbose` with bundler 1.15.1
even though the platform flags were never specified. This was surfaced by #5724, which will be fixed by this PR.
### Was was your diagnosis of the problem?
My diagnosis was that default values of options were being printed.
### What is your fix for the problem, implemented in this PR?
My fix is to filter out the default values before getting Thor
### Why did you choose this fix out of the possible options?
I chose this fix because there is no way, within the `CLI` instance, to tell which flags the user has explicitly given, so I felt that filtering out those options that had default values was the next-best thing.
(cherry picked from commit de7d488)
# Conflicts:
# lib/bundler/cli.rb
Contributor
Author
|
@indirect should I close this since we got rid of the |
Contributor
Author
|
@indirect ping? |
|
Now that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that
bundle installwould default to always updating the cache invendor/bundle(if it existed).Was was your diagnosis of the problem?
My diagnosis was that the default for the
--cacheflag should befalseinstead oftrue.What is your fix for the problem, implemented in this PR?
My fix is to invert the default on 2.0, using a feature flag. Taken from #3555.
Why did you choose this fix out of the possible options?
I chose this fix because it allowed a feature flag for a breaking change in 2.0 and was minimally invasive.