Skip to content
This repository was archived by the owner on Apr 14, 2021. It is now read-only.

Sort all documented settings in the bundle-config man page#5839

Merged
bundlerbot merged 2 commits intomasterfrom
seg-sort-documented-settings
Jul 6, 2017
Merged

Sort all documented settings in the bundle-config man page#5839
bundlerbot merged 2 commits intomasterfrom
seg-sort-documented-settings

Conversation

@segiddins
Copy link
Copy Markdown
Contributor

What was the end-user problem that led to this PR?

The problem was we kept on adding new settings to the end of the list, making it completely unordered.

What was your diagnosis of the problem?

My diagnosis was we should order the list.

What is your fix for the problem, implemented in this PR?

My fix orders the list and tests that it is indeed ordered.

Why did you choose this fix out of the possible options?

I chose this fix because I could write a little script to do it.

@colby-swandale
Copy link
Copy Markdown
Member

Great work!

@bundlerbot r+

@bundlerbot
Copy link
Copy Markdown
Collaborator

📌 Commit 9dc8ceb has been approved by colby-swandale

@bundlerbot
Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9dc8ceb with merge cc31efa...

bundlerbot added a commit that referenced this pull request Jul 6, 2017
…wandale

Sort all documented settings in the bundle-config man page

### What was the end-user problem that led to this PR?

The problem was we kept on adding new settings to the end of the list, making it completely unordered.

### What was your diagnosis of the problem?

My diagnosis was we should order the list.

### What is your fix for the problem, implemented in this PR?

My fix orders the list and tests that it is indeed ordered.

### Why did you choose this fix out of the possible options?

I chose this fix because I could write a little script to do it.
@bundlerbot
Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-travis
Approved by: colby-swandale
Pushing cc31efa to master...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants