This repository was archived by the owner on Apr 14, 2021. It is now read-only.
[2.0] Add —all flag to bundle update#5722
Merged
bundlerbot merged 6 commits intomasterfrom Jun 15, 2017
Merged
Conversation
This will avoid spurious deprecation warnings
And require it on 2+
segiddins
force-pushed
the
seg-update-all-flag
branch
from
511a018 to
237f035
Compare
|
@bundlerbot r+ |
Collaborator
|
📌 Commit 237f035 has been approved by |
segiddins
changed the title
—all flag to bundle update—all flag to bundle update
Collaborator
bundlerbot
added a commit
that referenced
this pull request
Jun 15, 2017
Add `—all` flag to `bundle update` ### What was the end-user problem that led to this PR? The problem was that some users would think they needed to run `bundle update` instead of `bundle install`, and we want such a (potentially) destructive action to require more explicit user approval. ### Was was your diagnosis of the problem? My diagnosis was that `bundle update` shouldn't implicitly update _everything_ without an acknowledgement that it will do so. ### What is your fix for the problem, implemented in this PR? My fix, based on #2646, it to require `bundle update --all` for the current `bundle update` behavior. ### Why did you choose this fix out of the possible options? I chose this fix because it was already on 2-0-dev, courtesy of rubygems/bundler-features#18.
Collaborator
|
☀️ Test successful - status-travis |
This was referenced Jun 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that some users would think they needed to run
bundle updateinstead ofbundle install, and we want such a (potentially) destructive action to require more explicit user approval.Was was your diagnosis of the problem?
My diagnosis was that
bundle updateshouldn't implicitly update everything without an acknowledgement that it will do so.What is your fix for the problem, implemented in this PR?
My fix, based on #2646, it to require
bundle update --allfor the currentbundle updatebehavior.Why did you choose this fix out of the possible options?
I chose this fix because it was already on 2-0-dev, courtesy of rubygems/bundler-features#18.