This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Add a feature flag for bundle update —source NAME not unlocking a gem with that name#5727
Merged
bundlerbot merged 1 commit intomasterfrom Jun 19, 2017
Merged
Conversation
|
@bundlerbot r+ |
Collaborator
|
📌 Commit 0d5ec16 has been approved by |
Collaborator
|
☔ The latest upstream changes (presumably #5719) made this pull request unmergeable. Please resolve the merge conflicts. |
Collaborator
|
🔒 Merge conflict |
…em with that name
segiddins
force-pushed
the
seg-update-source-feature-flag
branch
from
0d5ec16 to
8d94491
Compare
Contributor
Author
|
@bundlerbot r=indirect |
Collaborator
|
📌 Commit 8d94491 has been approved by |
Collaborator
bundlerbot
added a commit
that referenced
this pull request
Jun 19, 2017
Add a feature flag for `bundle update —source NAME` not unlocking a gem with that name ### What was the end-user problem that led to this PR? The problem is that `bundle update --source NAME` will unlock a _gem_ with that name, in addition to the source. ### Was was your diagnosis of the problem? My diagnosis was that we unlocked based on `spec.name` instead of `spec.source.name`. ### What is your fix for the problem, implemented in this PR? My fix is to put this backwards-compatibility hack behind a feature flag that will turn off on 2.0. ### Why did you choose this fix out of the possible options? I chose this fix because it allows the current behavior to continue for those who depend upon it, but the hack will be disabled by default on 2.0, or when `unlock_source_unlocks_spec` is set to true.
Collaborator
|
☀️ Test successful - status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem is that
bundle update --source NAMEwill unlock a gem with that name, in addition to the source.Was was your diagnosis of the problem?
My diagnosis was that we unlocked based on
spec.nameinstead ofspec.source.name.What is your fix for the problem, implemented in this PR?
My fix is to put this backwards-compatibility hack behind a feature flag that will turn off on 2.0.
Why did you choose this fix out of the possible options?
I chose this fix because it allows the current behavior to continue for those who depend upon it, but the hack will be disabled by default on 2.0, or when
unlock_source_unlocks_specis set to true.