This repository was archived by the owner on Apr 14, 2021. It is now read-only.
[2.0] Suppress Using … messages during installation when a version has not changed#5790
Merged
bundlerbot merged 2 commits intomasterfrom Jul 5, 2017
Merged
[2.0] Suppress Using … messages during installation when a version has not changed#5790bundlerbot merged 2 commits intomasterfrom
Using … messages during installation when a version has not changed#5790bundlerbot merged 2 commits intomasterfrom
Conversation
Collaborator
|
☔ The latest upstream changes (presumably #5788) made this pull request unmergeable. Please resolve the merge conflicts. |
segiddins
force-pushed
the
seg-suppress-using-messages
branch
from
d870da2 to
6f84b75
Compare
Contributor
Author
|
Rebased |
Collaborator
|
☔ The latest upstream changes (presumably #5782) made this pull request unmergeable. Please resolve the merge conflicts. |
segiddins
force-pushed
the
seg-suppress-using-messages
branch
from
6f84b75 to
8b8c798
Compare
Contributor
Author
|
2.0 specs updated, please review |
segiddins
force-pushed
the
seg-suppress-using-messages
branch
from
8b8c798 to
7622270
Compare
|
I really like using Bundler more after this change, 💯 @bundlerbot r+ |
Collaborator
|
📌 Commit 7622270 has been approved by |
Collaborator
bundlerbot
added a commit
that referenced
this pull request
Jul 5, 2017
[2.0] Suppress `Using …` messages during installation when a version has not changed ### What was the end-user problem that led to this PR? The problem was that `bundle install` output can get very verbose, even when Bundler is not doing anything. See rubygems/bundler-features#33. ### Was was your diagnosis of the problem? My diagnosis was that bundler was printing a bunch of `Using name (version)` messages, even when we were already using that gem at the same version. ### What is your fix for the problem, implemented in this PR? My fix is to introduce a feature flag (enabled by default on 2.0), that will only print those extra `Using` messages when `--verbose` is passed, and will continue to print them when there was an old version we can tell users about. Note that we still print a message when installing a gem for the first time. ### Why did you choose this fix out of the possible options? I chose this fix because it was essentially what had been done in #3872, and allows for easy feature-flagging.
Collaborator
|
☀️ Test successful - status-travis |
This was referenced Jul 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that
bundle installoutput can get very verbose, even when Bundler is not doing anything.See rubygems/bundler-features#33.
Was was your diagnosis of the problem?
My diagnosis was that bundler was printing a bunch of
Using name (version)messages, even when we were already using that gem at the same version.What is your fix for the problem, implemented in this PR?
My fix is to introduce a feature flag (enabled by default on 2.0), that will only print those extra
Usingmessages when--verboseis passed, and will continue to print them when there was an old version we can tell users about. Note that we still print a message when installing a gem for the first time.Why did you choose this fix out of the possible options?
I chose this fix because it was essentially what had been done in #3872, and allows for easy feature-flagging.