Remove set_value(value, name) from ReadWriteHandle#256
Merged
bmagyar merged 1 commit intoros-controls:masterfrom Dec 4, 2020
Merged
Remove set_value(value, name) from ReadWriteHandle#256bmagyar merged 1 commit intoros-controls:masterfrom
bmagyar merged 1 commit intoros-controls:masterfrom
Conversation
bmagyar
force-pushed
the
remove-set-value-w-name-from-handles
branch
from
4d20972 to
c1a3435
Compare
Contributor
|
You said it was requried due to the limit implementation in #203 (comment) Can you elaborate as to why is not needed anymore? |
destogl
approved these changes
Dec 2, 2020
Member
destogl
left a comment
destogl
left a comment
There was a problem hiding this comment.
If you say so. The PR is clean.
Member
Author
|
@v-lopez I've explained this in the opening post |
destogl
added a commit
to b-robotized-forks/ros2_control
that referenced
this pull request
Aug 11, 2022
* Fixed ros-controls#255 * correct include in correct header * Correct order of includes. Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #222
These were added for
joint_limits_interfacebut are a little messy in this new API. We'll reworkjoint_limits_interfacewith it's own handles, similarly to transmissions where this API can be allowed.