Merged
Conversation
Karsten1987
force-pushed
the
remove_logical_components
branch
from
114e8b4 to
f566057
Compare
Karsten1987
force-pushed
the
remodel_component_interfaces
branch
from
32bf738 to
127008d
Compare
bmagyar
reviewed
Oct 23, 2020
bmagyar
reviewed
Oct 24, 2020
bmagyar
requested changes
Oct 24, 2020
Member
bmagyar
left a comment
bmagyar
left a comment
There was a problem hiding this comment.
Looks good in general. Happy to merge once we settled the std::move point.
bmagyar
requested changes
Oct 26, 2020
Karsten1987
force-pushed
the
remodel_component_interfaces
branch
from
5a27bf8 to
4570e39
Compare
destogl
reviewed
Oct 29, 2020
Member
There was a problem hiding this comment.
I added a few discussion points.
Most importantly: I am not sure we need templates with Handles/Interfaces. Or we could use templates to set the data type of Handle/Interface (in general it has not be double, it could be also bool for valves or some status string)
hardware_interface/include/hardware_interface/components/system_interface.hpp
Show resolved
Hide resolved
hardware_interface/include/hardware_interface/hardware_info.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
bmagyar
force-pushed
the
remodel_component_interfaces
branch
from
9f82e64 to
608ad83
Compare
Member
|
I've rebased this PR after merging #209 |
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 31.41% 32.73% +1.31%
==========================================
Files 38 44 +6
Lines 2489 2688 +199
Branches 1638 1734 +96
==========================================
+ Hits 782 880 +98
- Misses 251 258 +7
- Partials 1456 1550 +94
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
approved these changes
Nov 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second part of #164
Introduces
StateHandleandCommandHandle.Adapts the hardware components interfaces to instantiate these handles given the configuration info passed to the components on a prior call to
configure.Sits on top of #201