Skip to content

Remove set_value(value, name) from ReadWriteHandle #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmagyar merged 1 commit into from
Dec 4, 2020
Merged

Remove set_value(value, name) from ReadWriteHandle #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions hardware_interface/include/hardware_interface/handle.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,20 +120,6 @@ class ReadWriteHandle : public ReadOnlyHandle<HandleType>
THROW_ON_NULLPTR(this->value_ptr_);
*this->value_ptr_ = value;
}

void set_value(const std::string & name, double value)
{
THROW_ON_NULLPTR(this->value_ptr_);
this->name_ = name;
*this->value_ptr_ = value;
}

void set_value(const char * name, double value)
{
THROW_ON_NULLPTR(this->value_ptr_);
this->name_ = name;
*this->value_ptr_ = value;
}
};

class StateInterface : public ReadOnlyHandle<StateInterface>
Expand Down