Added starting of resources into CM and RM#240
Merged
bmagyar merged 10 commits intoros-controls:masterfrom Dec 2, 2020
Merged
Conversation
Merged
Contributor
|
If you leave out the changes for the controller manager, this branch should be technically possible to merge straight into master, shouldn't it? |
Closed
Member
Author
bmagyar
requested changes
Nov 22, 2020
hardware_interface/include/hardware_interface/components/base_interface.hpp
Outdated
Show resolved
Hide resolved
Karsten1987
force-pushed
the
use_resource_manager
branch
from
2c200d9 to
1975fd8
Compare
bmagyar
force-pushed
the
use_resource_manager
branch
from
5f20840 to
0f14004
Compare
destogl
force-pushed
the
add_resource_starting
branch
from
d7e849e to
c6f41bf
Compare
Member
Author
destogl
commented
Nov 26, 2020
| } | ||
|
|
||
| protected: | ||
| HardwareInfo info_; |
Member
Author
There was a problem hiding this comment.
Should I rename info_ to hardware_info_? This is used in all child classes so that it could be more explicit for users.
Closed
bmagyar
force-pushed
the
add_resource_starting
branch
from
f75b24c to
c184002
Compare
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
…ests for starting
…interface.hpp Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
bmagyar
force-pushed
the
add_resource_starting
branch
from
c184002 to
01dc008
Compare
bmagyar
approved these changes
Dec 2, 2020
destogl
added a commit
to b-robotized-forks/ros2_control
that referenced
this pull request
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple functionality for demo with Example 1 to work.