Conversation
15605a0 to
3470744
Compare
|
Introduced a common URDF within the test_robot_hardware package, which reflects and exports all three types of hardware components. Once the file is loaded, the system can be probed via a service call: |
|
@Karsten1987 Thanks for this! I updated the demo example in ros2_controls/ros2_control_demos#37 to work with this. To check the demo see README instructions. I had to create a cusom branches since I did small changes to this PR in #240 and a small chnage to |
|
I am finally putting this up for review. I've remodeled the controller manager and resource manager to load the hardware dynamically. That also revokes the dependency on the test_robot_hardware package, which could then eventually be reworked to store a common set of test materials, such as test controllers, test hardware components and their URDFs. Please be aware that this PR will break the existing controller interfaces and all controllers within |
controller_interface/include/controller_interface/controller_interface.hpp
Show resolved
Hide resolved
controller_interface/include/controller_interface/controller_interface.hpp
Show resolved
Hide resolved
controller_interface/include/controller_interface/controller_interface.hpp
Outdated
Show resolved
Hide resolved
controller_interface/include/controller_interface/controller_interface.hpp
Outdated
Show resolved
Hide resolved
controller_manager/include/controller_manager/controller_manager.hpp
Outdated
Show resolved
Hide resolved
controller_manager/include/controller_manager/controller_manager.hpp
Outdated
Show resolved
Hide resolved
hardware_interface/include/hardware_interface/resource_manager.hpp
Outdated
Show resolved
Hide resolved
16dc984 to
fb3bdb6
Compare
|
What are the plans with the packages the build is broken on? |
|
I see only an issue with joint_limits_interface. transmission_interface will change anyway and it should be kind of independent from all this. Are there any other issues you see? |
|
I think that the joint limit interface can safely be ignored for now. I believe that we actually don't need a dedicated package for this. The functionality can easily be incorporated within either the hardware_interface or into a default component package. Interface seems to be wrong in this case then. |
74b5d59 to
fc4afe7
Compare
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> sort state interfaces in cli Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
…nterface.hpp Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
5f20840 to
0f14004
Compare
|
I updated the code for joint limit interface in PR #271. Discussion about moving these files into hardware_interface is in there.
|
Last part of #164 and closes #164
Currently sits on top of #216 and addresses the comment in here.
To start the node one can pass in a URDF as such: