Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
=======================================
Coverage 34.61% 34.61%
=======================================
Files 52 52
Lines 2981 2981
Branches 1855 1855
=======================================
Hits 1032 1032
Misses 310 310
Partials 1639 1639
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
Author
|
Moved to #240 |
destogl
pushed a commit
to b-robotized-forks/ros2_control
that referenced
this pull request
Aug 11, 2022
…with closed loop controller (ros-controls#239) * Add velocity pid support. * Remove incorrect init test for only velocity command interface. * Add clarification comments for pid aux variables. Adapt update loop. * Change dt for pid to appropriate measure. * Improve partial commands for velocity-only mode. * Extend tests to use velocity-only mode. * Increase timeout for velocity-only mode parametrized tests. * add is_same_sign for better refactor * refactor boolean logic * set velocity to 0.0 on deactivate Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package adds default functionality for components introducing an additional layer.
This should replace #180 using new components design from #207.
It creates package mentioned in #219.