Skip to content

adapt component parser to new xml schema#209

Merged
bmagyar merged 3 commits intomasterfrom
kk_component_parser
Oct 30, 2020
Merged

adapt component parser to new xml schema#209
bmagyar merged 3 commits intomasterfrom
kk_component_parser

Conversation

@Karsten1987
Copy link
Copy Markdown
Contributor

addresses the concerns raised in ros-controls/roadmap#28 (comment)

Copy link
Copy Markdown
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise looks good to me!

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #209 into master will decrease coverage by 20.88%.
The diff coverage is 32.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #209       +/-   ##
===========================================
- Coverage   36.61%   15.72%   -20.89%     
===========================================
  Files          42      116       +74     
  Lines        1726     9066     +7340     
  Branches     1080     1880      +800     
===========================================
+ Hits          632     1426      +794     
- Misses        100     5973     +5873     
- Partials      994     1667      +673     
Flag Coverage Δ
#unittests 15.72% <32.42%> (-20.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r_manager/test/test_controller/test_controller.cpp 100.00% <ø> (ø)
...r_manager/test/test_controller/test_controller.hpp 100.00% <ø> (ø)
...e/include/hardware_interface/actuator_hardware.hpp 100.00% <ø> (ø)
...hardware_interface/actuator_hardware_interface.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/components/joint.hpp 100.00% <ø> (ø)
...e/include/hardware_interface/components/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/handle.hpp 73.33% <0.00%> (-5.24%) ⬇️
...ace/include/hardware_interface/sensor_hardware.hpp 100.00% <ø> (ø)
...e/hardware_interface/sensor_hardware_interface.hpp 100.00% <ø> (ø)
...ace/include/hardware_interface/system_hardware.hpp 100.00% <ø> (ø)
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5304e30...c1125e6. Read the comment docs.

Copy link
Copy Markdown
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you updated the urdfs by hand? Please update the example URDFs from the example URDFs page we have here: https://github.com/ros-controls/roadmap/blob/master/design_drafts/components_architecture_and_urdf_examples.md

Using min_position_value has been gone for a while and should be updated.
I saw that some asserts were removed due to this, please re-add them.

Copy link
Copy Markdown
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Karsten1987 happy to go ahead with this once the CI is happy. I can do a follow up update of the example urdfs provided there is an issue for it.

Karsten1987 and others added 3 commits October 27, 2020 06:51
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
@bmagyar bmagyar force-pushed the kk_component_parser branch from c1125e6 to 46d18bf Compare October 27, 2020 06:55
@bmagyar
Copy link
Copy Markdown
Member

bmagyar commented Oct 27, 2020

As per #214 I'm ignoring the foxy source job on this one. @Karsten1987 let me know if you are happy with the changes I put on top and if yes, feel free to merge this

@bmagyar bmagyar merged commit bce8d90 into master Oct 30, 2020
@Karsten1987 Karsten1987 deleted the kk_component_parser branch October 30, 2020 16:21
destogl pushed a commit to b-robotized-forks/ros2_control that referenced this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants