Merged
Conversation
e590619 to
52e5441
Compare
destogl
requested changes
Oct 22, 2020
Member
destogl
left a comment
There was a problem hiding this comment.
Find/Replace All didn't work perfectly in all cases.
Can you also add one more example showing the "user-friendly" joints?
1.1 Industrial Robots with only one interface - user-friendly Joints
The `ros2_control_components/PositionJoint` Joint is "position" command and state handles.
<ros2_control name="RRBotSystemPositionOnly" type="system">
<hardware>
<classType>ros2_control_demo_hardware/RRBotSystemPositionOnlyHardware</classType>
<param name="example_param_write_for_sec">2</param>
<param name="example_param_read_for_sec">2</param>
</hardware>
<joint name="joint1">
<classType>ros2_control_components/PositionJoint</classType>
<param name="min">-1</param>
<param name="max">1</param>
</joint>
<joint name="joint2">
<classType>ros2_control_components/PositionJoint</classType>
<param name="min">-1</param>
<param name="max">1</param>
</joint>
</ros2_control>
bmagyar
commented
Oct 22, 2020
bmagyar
commented
Oct 22, 2020
bmagyar
commented
Oct 22, 2020
bmagyar
commented
Oct 22, 2020
bmagyar
commented
Oct 22, 2020
bmagyar
commented
Oct 22, 2020
bmagyar
commented
Oct 22, 2020
bmagyar
commented
Oct 22, 2020
bmagyar
commented
Oct 22, 2020
bmagyar
commented
Oct 22, 2020
Member
Author
|
@destogl thanks for the feedback. I've updated your suggestons to not add minmax where they werent originally. |
Member
Author
|
I'd also prefer to not have the simple helpers in here yet. Theres a lot to implement first. perhaps a new page with extension proposals? |
destogl
requested changes
Oct 23, 2020
Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
Contributor
|
are we having a follow up ticket to this for updating the parser? |
Contributor
|
Also, shouldn't we rename |
This was referenced Oct 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #27