Skip to content

Update URDF examples#28

Merged
bmagyar merged 4 commits intoros-controls:masterfrom
bmagyar:update-urdf-examples
Oct 23, 2020
Merged

Update URDF examples#28
bmagyar merged 4 commits intoros-controls:masterfrom
bmagyar:update-urdf-examples

Conversation

@bmagyar
Copy link
Copy Markdown
Member

@bmagyar bmagyar commented Oct 22, 2020

Following #27

@bmagyar bmagyar force-pushed the update-urdf-examples branch from e590619 to 52e5441 Compare October 22, 2020 10:59
Copy link
Copy Markdown
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find/Replace All didn't work perfectly in all cases.

Can you also add one more example showing the "user-friendly" joints?

1.1 Industrial Robots with only one interface - user-friendly Joints

The `ros2_control_components/PositionJoint` Joint is "position" command and state handles.


  <ros2_control name="RRBotSystemPositionOnly" type="system">
    <hardware>
      <classType>ros2_control_demo_hardware/RRBotSystemPositionOnlyHardware</classType>
      <param name="example_param_write_for_sec">2</param>
      <param name="example_param_read_for_sec">2</param>
    </hardware>
    <joint name="joint1">
      <classType>ros2_control_components/PositionJoint</classType>
      <param name="min">-1</param>
      <param name="max">1</param>
    </joint>
    <joint name="joint2">
      <classType>ros2_control_components/PositionJoint</classType>
      <param name="min">-1</param>
      <param name="max">1</param>
    </joint>
  </ros2_control>

Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
@bmagyar
Copy link
Copy Markdown
Member Author

bmagyar commented Oct 22, 2020

@destogl thanks for the feedback. I've updated your suggestons to not add minmax where they werent originally.

@bmagyar
Copy link
Copy Markdown
Member Author

bmagyar commented Oct 22, 2020

I'd also prefer to not have the simple helpers in here yet. Theres a lot to implement first. perhaps a new page with extension proposals?

Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
@bmagyar bmagyar merged commit 1352e27 into ros-controls:master Oct 23, 2020
@Karsten1987
Copy link
Copy Markdown
Contributor

are we having a follow up ticket to this for updating the parser?

@Karsten1987
Copy link
Copy Markdown
Contributor

Also, shouldn't we rename classType to something else? what about just naming it plugin similar to what the gazebo tag is using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants