Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show RAM use and data rate when hovering an entity in stream view #2997

Merged
merged 8 commits into from
Aug 16, 2023
Merged

Show RAM use and data rate when hovering an entity in stream view #2997

merged 8 commits into from
Aug 16, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 16, 2023 •
edited
Loading

image

image

Checklist

@emilk emilk added enhancement New feature or request ui concerns graphical user interface 📺 re_viewer affects re_viewer itself labels Aug 16, 2023
@emilk emilk marked this pull request as draft August 16, 2023 07:45
@emilk emilk changed the title Show total RAM use when hovering an entity in stream view Show RAM use and data rate when hovering an entity in stream view Aug 16, 2023
@emilk emilk marked this pull request as ready for review August 16, 2023 08:31
@Wumpf
Copy link
Member

Wumpf commented Aug 16, 2023

pretty cool to have this, but are we sure we want to display it that prominently in the tooltip? 🤔

@emilk
Copy link
Member Author

emilk commented Aug 16, 2023

pretty cool to have this, but are we sure we want to display it that prominently in the tooltip? 🤔

I'm not quite sure where else to show it. In the selection menu we always show the current state of an entity (i.e. at the currently selected time), so adding a "lifetime" stat like this there felt out-of-place

@Wumpf Wumpf self-requested a review August 16, 2023 09:07
Wumpf
Wumpf approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

But I don't understand why this doesn't show a rate on the web demo:
image

crates/re_data_ui/src/item_ui.rs
// events we have a span of 2 seconds, and 3 MiB,
// but the data rate is still 1 MiB/s.
//
// <-----2 sec----->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useful illustration, nice 👍

@emilk
Copy link
Member Author

emilk commented Aug 16, 2023

@Wumpf old build - it works now!

@emilk emilk merged commit 91968c6 into main Aug 16, 2023
@emilk emilk deleted the emilk/show-data-volume branch August 16, 2023 10:43
@abey79 abey79 mentioned this pull request Aug 30, 2023
Merged
3 tasks
abey79 added a commit that referenced this pull request Sep 1, 2023
@abey79
Use ListItem in Stream Tree UI (#3153)
6451f78 
### What

Use `ListItem` in the Stream Tree UI.

- Consistent UI in the stream tree (vs. stuff in the left panel)
- Revamped look of the selection/hovered state in the timeline itself.
- Cleaned up the code for the "Entity/instance hover cards". Now
hovering instances in the blueprint tree _also_ displays storage use
from #2997
- Improved `ListItem`
- New attribute to control the width allocation mode (currently: max
width or fit to label)
- Improved click/hover sensing to cover the full span area (= hover
highlight), not just the actually allocated space (icon + label). That
improves the behaviour of the left panel trees too.

Fixes #3045
Fixes #2738 (if we accept that dropdown button are "close enough" and
will be improved with #2734 anyways)
Fixes #2860

<img width="1817" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/5492ae03-0da0-4417-b7a1-2bedd4da4e8c">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3153) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3153)
- [Docs
preview](https://rerun.io/preview/2c54fda5373adf90d1407dc161f65f2242dcd4a3/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/2c54fda5373adf90d1407dc161f65f2242dcd4a3/examples)
<!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show per-entity data rate and volume
2 participants
@emilk @Wumpf