Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lines in timeline should go between data, not through it #2860

Closed
Tracked by #2670
martenbjork opened this issue Jul 28, 2023 · 4 comments · Fixed by #3153
Closed
Tracked by #2670

Lines in timeline should go between data, not through it #2860

martenbjork opened this issue Jul 28, 2023 · 4 comments · Fixed by #3153
Labels
ui concerns graphical user interface

Comments

@martenbjork
Copy link
Contributor

martenbjork commented Jul 28, 2023

(Unless someone genuinely thinks the current way is better!)

Current (lines go through the data)

image

Desired (lines sit between the data)

image
@abey79
Copy link
Member

abey79 commented Jul 28, 2023

That blue line when selected should be gone as well, I suppose?

image

@martenbjork
Copy link
Contributor Author

That blue line when selected should be gone as well, I suppose?

Yes! I think the highlighting can be done in better ways (like highlighting the data, or the row's background)

@emilk emilk added the ui concerns graphical user interface label Aug 8, 2023
@emilk
Copy link
Member

emilk commented Aug 8, 2023

I changed from "lines as separators" to "lines as things upon which data hangs" as part of #1557 as I think it looked better with the new data density graphs

@abey79
Copy link
Member

abey79 commented Aug 8, 2023

I'm probably going to leave this one aside until the incoming, more global redesign around streams. Let's settle this question on @martenbjork's (future) design proposals directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui concerns graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants