Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show per-entity data rate and volume #2435

Closed
emilk opened this issue Jun 14, 2023 · 0 comments · Fixed by #2997
Closed

Show per-entity data rate and volume #2435

emilk opened this issue Jun 14, 2023 · 0 comments · Fixed by #2997
Assignees
Labels
enhancement New feature or request

Comments

@emilk
Copy link
Member

emilk commented Jun 14, 2023

We have users that want to save bandwidth and storage, but don't know what is taking up space.

If we can hover an entity stream and see "This is 15GB, 24MB/s" it would be very helpful.

Of course, this would be the uncompressed data rate, because seeing the compressed data rate is much much more difficult.

@emilk emilk added the enhancement New feature or request label Jun 14, 2023
@emilk emilk self-assigned this Aug 15, 2023
emilk added a commit that referenced this issue Aug 16, 2023
An off-by-one bug in `estimated_bytes_size` caused the size estimations
of Tensors to completely ignore the actual payload, causing the memory
consumption of images to be vastly underestimated.

I decided to rewrite the code to be more clear for future readers.

This discovered a difference in how validity bitmaps are written by Rust
and Python+C++, fixed in
a828441.

To help find this problem a lot of work was also put into improving the
output of `scripts/ci/run_e2e_roundtrip_tests.py`.

* Discovered while working on
#2435

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2991) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2991)
- [Docs
preview](https://rerun.io/preview/pr%3Aemilk%2Ffix-size-estimation-bug/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aemilk%2Ffix-size-estimation-bug/examples)

---------

Co-authored-by: Jeremy Leibs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant