Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ListItem in Stream Tree UI #3153

Merged
merged 11 commits into from
Sep 1, 2023
Merged

Use ListItem in Stream Tree UI #3153

merged 11 commits into from
Sep 1, 2023

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Aug 30, 2023 •
edited
Loading

What

Use ListItem in the Stream Tree UI.

  • Consistent UI in the stream tree (vs. stuff in the left panel)
  • Revamped look of the selection/hovered state in the timeline itself.
  • Cleaned up the code for the "Entity/instance hover cards". Now hovering instances in the blueprint tree also displays storage use from Show RAM use and data rate when hovering an entity in stream view #2997
  • Improved ListItem
    • New attribute to control the width allocation mode (currently: max width or fit to label)
    • Improved click/hover sensing to cover the full span area (= hover highlight), not just the actually allocated space (icon + label). That improves the behaviour of the left panel trees too.

Fixes #3045
Fixes #2738 (if we accept that dropdown button are "close enough" and will be improved with #2734 anyways)
Fixes #2860

image

Checklist

@abey79 abey79 added the ui concerns graphical user interface label Aug 30, 2023
@abey79 abey79 marked this pull request as ready for review August 31, 2023 12:10
@abey79 abey79 requested a review from martenbjork August 31, 2023 12:11
emilk
emilk reviewed Sep 1, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused about WidthAllocationMode

crates/re_viewer/src/ui/recordings_panel.rs Outdated Show resolved Hide resolved
crates/re_time_panel/src/lib.rs Show resolved Hide resolved
crates/re_time_panel/src/lib.rs Outdated Show resolved Hide resolved
crates/re_ui/src/list_item.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Size changes

Name main 3153/merge Change
plots.rrd 194.56 kiB 184.32 kiB -5.26%

@abey79 abey79 merged commit 6451f78 into main Sep 1, 2023
@abey79 abey79 deleted the antoine/list-item-streams branch September 1, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk left review comments

@martenbjork martenbjork Awaiting requested review from martenbjork

Assignees
No one assigned
Labels
ui concerns graphical user interface
Projects
None yet
Milestone
0.9 - Codegen, Type Oriented Api
2 participants
@abey79 @emilk