Clean up our examples #2424
Merged
Clean up our examples #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
approved these changes
Jun 14, 2023
7 tasks
abey79
added a commit
that referenced
this pull request
Jun 14, 2023
### What Updates the titles, and adds tags to all "python examples with real data" (a separate PR is needed for the "fake data" examples). Renames: | before | after | | --- | --- | | arkitscenes | arkit_scenes | | colmap | structure_from_motion | | deep_sdf | signed_distance_fields | | dicom | dicom_mri | | mp_pose | human_pose_tracking | | nyud | rgbd | | opencv_canny | live_camera_edge_detection | | ros | ros_node | | segment_anything | segment_anything_model | | stable_diffusion | depth_guided_stable_diffusion | | tracking_hf_opencv | detect_and_track_objects | In order to minimise merge issues, this is best updated and merged AFTER: - #2419 - #2420 - #2418 - #2424 - #2426 - #2360 TODO - [x] Update names script names - [x] Update any references to the scripts - [ ] ~~Mirror updates for Rust examples~~ (none of the renamed examples have rust counterparts) - [x] Convert tags to list - [x] Quick typo/grammar pass with pycharm's checker ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [ ] I've included a screenshot or gif (if applicable) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2416 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/3fb07ee/docs Examples preview: https://rerun.io/preview/3fb07ee/examples <!-- pr-link-docs:end --> --------- Co-authored-by: Antoine Beyeler <[email protected]>
emilk
added a commit
that referenced
this pull request
Jun 15, 2023
Various fixes I found when updating our demo list. See commit messages. * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2424 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/7b3027e/docs Examples preview: https://rerun.io/preview/7b3027e/examples <!-- pr-link-docs:end -->
emilk
pushed a commit
that referenced
this pull request
Jun 15, 2023
Updates the titles, and adds tags to all "python examples with real data" (a separate PR is needed for the "fake data" examples). Renames: | before | after | | --- | --- | | arkitscenes | arkit_scenes | | colmap | structure_from_motion | | deep_sdf | signed_distance_fields | | dicom | dicom_mri | | mp_pose | human_pose_tracking | | nyud | rgbd | | opencv_canny | live_camera_edge_detection | | ros | ros_node | | segment_anything | segment_anything_model | | stable_diffusion | depth_guided_stable_diffusion | | tracking_hf_opencv | detect_and_track_objects | In order to minimise merge issues, this is best updated and merged AFTER: - #2419 - #2420 - #2418 - #2424 - #2426 - #2360 TODO - [x] Update names script names - [x] Update any references to the scripts - [ ] ~~Mirror updates for Rust examples~~ (none of the renamed examples have rust counterparts) - [x] Convert tags to list - [x] Quick typo/grammar pass with pycharm's checker * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [ ] I've included a screenshot or gif (if applicable) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2416 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/3fb07ee/docs Examples preview: https://rerun.io/preview/3fb07ee/examples <!-- pr-link-docs:end --> --------- Co-authored-by: Antoine Beyeler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Various fixes I found when updating our demo list. See commit messages.
Checklist
PR Build Summary: https://build.rerun.io/pr/2424
Docs preview: https://rerun.io/preview/7b3027e/docs
Examples preview: https://rerun.io/preview/7b3027e/examples