-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update web examples #2420
Merged
Merged
Update web examples #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
examples
Issues relating to the Rerun examples
🕸️ web
regarding running the viewer in a browser
labels
Jun 13, 2023
emilk
force-pushed
the
emilk/update-web-examples
branch
from
June 13, 2023 19:04
13a30f7
to
c66337e
Compare
7 tasks
emilk
force-pushed
the
emilk/update-web-examples
branch
from
June 14, 2023 07:58
fd4e944
to
e4e96c8
Compare
emilk
force-pushed
the
emilk/update-web-examples
branch
from
June 14, 2023 09:16
dc96a14
to
20e8db7
Compare
abey79
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (but who am I to say 😅). I'll have to do a second pass on the web demo stuff anyways.
Couldn't help but write #2429 |
abey79
added a commit
that referenced
this pull request
Jun 14, 2023
### What Updates the titles, and adds tags to all "python examples with real data" (a separate PR is needed for the "fake data" examples). Renames: | before | after | | --- | --- | | arkitscenes | arkit_scenes | | colmap | structure_from_motion | | deep_sdf | signed_distance_fields | | dicom | dicom_mri | | mp_pose | human_pose_tracking | | nyud | rgbd | | opencv_canny | live_camera_edge_detection | | ros | ros_node | | segment_anything | segment_anything_model | | stable_diffusion | depth_guided_stable_diffusion | | tracking_hf_opencv | detect_and_track_objects | In order to minimise merge issues, this is best updated and merged AFTER: - #2419 - #2420 - #2418 - #2424 - #2426 - #2360 TODO - [x] Update names script names - [x] Update any references to the scripts - [ ] ~~Mirror updates for Rust examples~~ (none of the renamed examples have rust counterparts) - [x] Convert tags to list - [x] Quick typo/grammar pass with pycharm's checker ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [ ] I've included a screenshot or gif (if applicable) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2416 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/3fb07ee/docs Examples preview: https://rerun.io/preview/3fb07ee/examples <!-- pr-link-docs:end --> --------- Co-authored-by: Antoine Beyeler <[email protected]>
emilk
added a commit
that referenced
this pull request
Jun 15, 2023
Closes #2260 ### What I've updated the list of examples to use at demo.rerun.io. Sizes are pretty good now with JPEG compression, and all of these will be streamed once we have #2262 (except DICOM, which is just one big tensor) ``` arkitscenes: 42.7 MB colmap: 7.6 MB dicom: 67.7 MB mp_pose: 58.2 MB plots: 0.1 MB tracking_hf_opencv: 58.2 MB ``` The CSS here could use some work though in a folllow-up PR: ![image](https://github.com/rerun-io/rerun/assets/1148717/0ac44586-6438-4976-b959-2e0f327b989f) Some of the names here have been updated, following the lead of #2416 ### How to test it ``` scripts/build_demo_app.py (cd web_demo && basic-http-server -a 0.0.0.0:8080 .) ``` This will also require a manual deploy to `demo.rerun.io` at some point. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2420 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/07dd16b/docs Examples preview: https://rerun.io/preview/07dd16b/examples <!-- pr-link-docs:end -->
emilk
pushed a commit
that referenced
this pull request
Jun 15, 2023
Updates the titles, and adds tags to all "python examples with real data" (a separate PR is needed for the "fake data" examples). Renames: | before | after | | --- | --- | | arkitscenes | arkit_scenes | | colmap | structure_from_motion | | deep_sdf | signed_distance_fields | | dicom | dicom_mri | | mp_pose | human_pose_tracking | | nyud | rgbd | | opencv_canny | live_camera_edge_detection | | ros | ros_node | | segment_anything | segment_anything_model | | stable_diffusion | depth_guided_stable_diffusion | | tracking_hf_opencv | detect_and_track_objects | In order to minimise merge issues, this is best updated and merged AFTER: - #2419 - #2420 - #2418 - #2424 - #2426 - #2360 TODO - [x] Update names script names - [x] Update any references to the scripts - [ ] ~~Mirror updates for Rust examples~~ (none of the renamed examples have rust counterparts) - [x] Convert tags to list - [x] Quick typo/grammar pass with pycharm's checker * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [ ] I've included a screenshot or gif (if applicable) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2416 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/3fb07ee/docs Examples preview: https://rerun.io/preview/3fb07ee/examples <!-- pr-link-docs:end --> --------- Co-authored-by: Antoine Beyeler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2260
What
I've updated the list of examples to use at demo.rerun.io.
Sizes are pretty good now with JPEG compression, and all of these will be streamed once we have #2262 (except DICOM, which is just one big tensor)
The CSS here could use some work though in a folllow-up PR:
Some of the names here have been updated, following the lead of #2416
How to test it
This will also require a manual deploy to
demo.rerun.io
at some point.Checklist
PR Build Summary: https://build.rerun.io/pr/2420
Docs preview: https://rerun.io/preview/07dd16b/docs
Examples preview: https://rerun.io/preview/07dd16b/examples