Update titles and tags for examples with real data #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Jun 13, 2023
emilk
added a commit
that referenced
this pull request
Jun 14, 2023
Closes #2260 ### What I've updated the list of examples to use at demo.rerun.io. Sizes are pretty good now with JPEG compression, and all of these will be streamed once we have #2262 (except DICOM, which is just one big tensor) ``` arkitscenes: 42.7 MB colmap: 7.6 MB dicom: 67.7 MB mp_pose: 58.2 MB plots: 0.1 MB tracking_hf_opencv: 58.2 MB ``` The CSS here could use some work though in a folllow-up PR:  Some of the names here have been updated, following the lead of #2416 ### How to test it ``` scripts/build_demo_app.py (cd web_demo && basic-http-server -a 0.0.0.0:8080 .) ``` This will also require a manual deploy to `demo.rerun.io` at some point. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2420 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/07dd16b/docs Examples preview: https://rerun.io/preview/07dd16b/examples <!-- pr-link-docs:end -->
emilk
approved these changes
Jun 14, 2023
emilk
added a commit
that referenced
this pull request
Jun 15, 2023
Closes #2260 ### What I've updated the list of examples to use at demo.rerun.io. Sizes are pretty good now with JPEG compression, and all of these will be streamed once we have #2262 (except DICOM, which is just one big tensor) ``` arkitscenes: 42.7 MB colmap: 7.6 MB dicom: 67.7 MB mp_pose: 58.2 MB plots: 0.1 MB tracking_hf_opencv: 58.2 MB ``` The CSS here could use some work though in a folllow-up PR:  Some of the names here have been updated, following the lead of #2416 ### How to test it ``` scripts/build_demo_app.py (cd web_demo && basic-http-server -a 0.0.0.0:8080 .) ``` This will also require a manual deploy to `demo.rerun.io` at some point. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2420 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/07dd16b/docs Examples preview: https://rerun.io/preview/07dd16b/examples <!-- pr-link-docs:end -->
emilk
pushed a commit
that referenced
this pull request
Jun 15, 2023
Updates the titles, and adds tags to all "python examples with real data" (a separate PR is needed for the "fake data" examples). Renames: | before | after | | --- | --- | | arkitscenes | arkit_scenes | | colmap | structure_from_motion | | deep_sdf | signed_distance_fields | | dicom | dicom_mri | | mp_pose | human_pose_tracking | | nyud | rgbd | | opencv_canny | live_camera_edge_detection | | ros | ros_node | | segment_anything | segment_anything_model | | stable_diffusion | depth_guided_stable_diffusion | | tracking_hf_opencv | detect_and_track_objects | In order to minimise merge issues, this is best updated and merged AFTER: - #2419 - #2420 - #2418 - #2424 - #2426 - #2360 TODO - [x] Update names script names - [x] Update any references to the scripts - [ ] ~~Mirror updates for Rust examples~~ (none of the renamed examples have rust counterparts) - [x] Convert tags to list - [x] Quick typo/grammar pass with pycharm's checker * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [ ] I've included a screenshot or gif (if applicable) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2416 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/3fb07ee/docs Examples preview: https://rerun.io/preview/3fb07ee/examples <!-- pr-link-docs:end --> --------- Co-authored-by: Antoine Beyeler <[email protected]>
Closed
|
The old names are still being referred to in some places. For instance, |
2 tasks
emilk
pushed a commit
that referenced
this pull request
Jun 15, 2023
### What This PR fixes a bunch of places where renames from #2416 weren't applied.⚠️ It touches various build-related places, ~~due to the renaming of `colmap_fiat.rrd` into `structure_from_motion_fiat.rrd`~~, which is included in the SDK demo feature. Edit: `colmap_fiat.rrd` shouldn't be renamed, it corresponds to an actual Google dataset called `colmap_fiat`. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [ ] ~~I've included a screenshot or gif (if applicable)~~ <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2448 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/98e0eca/docs Examples preview: https://rerun.io/preview/98e0eca/examples <!-- pr-link-docs:end -->
emilk
pushed a commit
that referenced
this pull request
Jun 15, 2023
### What This PR fixes a bunch of places where renames from #2416 weren't applied.⚠️ It touches various build-related places, ~~due to the renaming of `colmap_fiat.rrd` into `structure_from_motion_fiat.rrd`~~, which is included in the SDK demo feature. Edit: `colmap_fiat.rrd` shouldn't be renamed, it corresponds to an actual Google dataset called `colmap_fiat`. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [ ] ~~I've included a screenshot or gif (if applicable)~~ <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2448 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/98e0eca/docs Examples preview: https://rerun.io/preview/98e0eca/examples <!-- pr-link-docs:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates the titles, and adds tags to all "python examples with real data" (a separate PR is needed for the "fake data" examples).
Renames:
In order to minimise merge issues, this is best updated and merged AFTER:
tracking_hf example: put scaled thing under its own root entity #2419jpeg_qualityparameter tolog_image#2418requeststo 2.31 with bug fix #2426TODO
Mirror updates for Rust examples(none of the renamed examples have rust counterparts)Checklist
PR Build Summary: https://build.rerun.io/pr/2416
Docs preview: https://rerun.io/preview/3fb07ee/docs
Examples preview: https://rerun.io/preview/3fb07ee/examples