Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix premature pausing when reaching end of still-streaming stream #2106

Merged
merged 5 commits into from
May 12, 2023
Merged

Fix premature pausing when reaching end of still-streaming stream #2106

merged 5 commits into from
May 12, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented May 12, 2023 •
edited by github-actions bot
Loading

What

Fixes regression caused by #2085

Closes #2103

Checklist

PR Build Summary: https://build.rerun.io/pr/2106

@emilk emilk added the 🪳 bug Something isn't working label May 12, 2023
jleibs
jleibs approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work for me (or at least I haven't gotten it to break yet).

jleibs
jleibs requested changes May 12, 2023
View reviewed changes
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work for notebooks yet... probably need to hunt down and figure out why the stream isn't being closed.

@emilk
Copy link
Member Author

emilk commented May 12, 2023 •
edited
Loading

This doesn't work for notebooks yet... probably need to hunt down and figure out why the stream isn't being closed.

Can you help with that? 🙏 I'm heading out now.
Feel free to push more stuff to the PR.

@jleibs jleibs mentioned this pull request May 12, 2023
Closed
2 tasks
@jleibs jleibs merged commit 223e0bd into main May 12, 2023
@jleibs jleibs deleted the emilk/fix-premature-pause branch May 12, 2023 17:01
This was referenced May 12, 2023
Closed
Closed
emilk added a commit that referenced this pull request May 15, 2023
@emilk
Add unit test of re_smart_channel is_connected
3f09a93 
Follow-up to #2106
This was referenced May 15, 2023
Merged
Merged
emilk added a commit that referenced this pull request May 16, 2023
@emilk
Add unit test of re_smart_channel is_connected (#2119)
c2e5fa9 
Follow-up to #2106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @jleibs